Avoid sending invalid location errors to telemetry#3682
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
server
Graphite App
st0012
approved these changes
Jul 23, 2025
vinistock
deleted the
07-22-avoid_sending_invalid_location_errors_to_telemetry
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
With the changes to position scanners being released for a while, we received no reports that indicate corrupted documents, but we do see the server receiving requests for invalid positions on occasion. This has no actual impact on features because if the document state changed, the editor will request for the features again and successfully get a response the second time.
I think it's safe to ignore these errors from telemetry.
Implementation
Added the invalid location error to our special case that doesn't include the
dataattribute, which makes the error be ignored by telemetry.Automated Tests
Added a test.