add highlight for do...end blocks#3061
Conversation
|
I have signed the CLA! |
|
Great! Wow, this reveals a different problem I was having then. When I tested your code the correct matching term was highlighted along with the wrong one. So I was actually using a legacy regex based highlighter without realizing it. 🙄 |
|
This pull request is being marked as stale because there was no activity in the last 2 months |
|
This pull request is being marked as stale because there was no activity in the last 2 months |
|
@vicocamacho I'm confused about this one. Is this PR related to #2929? Or does it just implement highlighting the matching The description has the Let me know if you want to bring this PR back. |
|
hey @vinistock, While I was investigating the error reported in #2929, I discovered that It turns out the issue was actually caused by Regex-based highlighting in Neovim. So while technically this PR does not solve that bug report, it does add a "missing" feature. I'm happy to bring back the PR if you think it is worth having. |
|
Yes! Let's do it. We should highlight both matching |
Motivation
Closes #2929
As I was investigating the problem with the issue above I discovered that the highlight functionality for do blocks was not implemented.
Implementation
This PR enhances the existing Highlight feature to add support for highlighting blocks.
Automated Tests
Added new expectations using the existing "do block" fixture files.
Manual Tests
Go to the start of a
doblock, it should highlight its matchingend