Go back to returning nil for cancelled requests#3024
Merged
Conversation
vinistock
added
server
Graphite App
alexcrocha
approved these changes
Jan 8, 2025
vinistock
deleted the
01-08-go_back_to_returning_nil_for_cancelled_requests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is a temporary revert to fix #3019 while we understand the correct response flow for retried cancelled requests.
This PR reverts the behaviour introduced in #2939, which didn't cause problems for NeoVim.
Implementation
I didn't perform a full revert of every single change, since we do want to ensure that we're following the spec. I just stopped returning the error and went back to returning a
nilresponse until we figure out what's going on.Automated Tests
Changed the test so that it asserts the current behaviour. We'll switch it back later.