feat(ci): add scaffolding tests for npm, pnpm, and yarn#3458
Draft
itsjustriley wants to merge 2 commits intomainfrom
Draft
feat(ci): add scaffolding tests for npm, pnpm, and yarn#3458itsjustriley wants to merge 2 commits intomainfrom
itsjustriley wants to merge 2 commits intomainfrom
Conversation
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Resolves developer-tools-team/issues/1042
There were no CI checks validating that
create-hydrogencorrectly scaffolds projects with different package managers. A bug inhandleDependencieswas silently causing--package-managerto be ignored when--install-depswas explicitlytrue— all scaffolded projects used npm regardless of the specified package manager.WHAT is this pull request doing?
CI scaffolding tests — Adds a new
test_scaffoldingjob to CI that uses a GitHub Actions matrix to test each package manager (npm, pnpm, yarn, bun) in parallel. Each matrix entry:create-hydrogenwith--package-managerBug fix — Adds a missing
elsebranch inhandleDependencies(
packages/cli/src/lib/onboarding/common.ts). When--install-depswastrueand--package-managerwas a known PM (notunknown),actualPackageManagerstayed as the default'npm'because neither theunknownnorundefinedbranches executed.Unit test — Verifies that
setupTemplatewithinstallDeps: trueandpackageManager: 'pnpm'callsinstallNodeModuleswithpnpm.HOW to test your changes?
The CI scaffolding tests run automatically on the PR.
Checklist
PR contains user-facing or noteworthy changes
changes