Skip to content

Conversation

@kdaviduik
Copy link
Contributor

@kdaviduik kdaviduik commented Feb 9, 2026

WHY are these changes introduced?

Closes https://github.com/Shopify/developer-tools-team/issues/1033.

When using shopify theme dev --theme-editor-sync, making schema changes to section files (e.g., adding/modifying settings in {% schema %} blocks) did not trigger the theme customizer to reload. Users had to manually refresh the customizer to see schema updates.

This is a regression since version 3.88.1.

WHAT is this pull request doing?

Bumps @shopify/theme-hot-reload from ^0.0.18 to ^0.0.22.

Root cause: The hot-reload client was only checking javascriptTag changes to trigger full page reloads, but ignored schemaTag changes that the server was already sending.

The fix existed upstream in v0.0.20+ (commit 4785747 in the theme-hot-reload package), which adds:

if (event.payload?.updatedFileParts?.javascriptTag ||
    event.payload?.updatedFileParts?.schemaTag) {
    return fullPageReload(event.key);
}

How to test your changes?

Note: I'm currently having 1Password issues so I'm locked out of the admin and haven't been able to manually test these myself

  1. Run shopify theme dev --theme-editor-sync in a theme directory
  2. Open the theme customizer in your browser
  3. Edit a section's {% schema %} block (e.g., add a new setting)
  4. Save the file
  5. Expected: The customizer reloads automatically and shows the new schema setting
  6. Before fix: No reload occurred; manual refresh was required

Measuring impact

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

The `--theme-editor-sync` flag was not triggering a reload in the theme
customizer when making schema changes to section files. Users had to
manually refresh the customizer to see schema updates.

Root cause: The `@shopify/theme-hot-reload` client (v0.0.18) was only
checking for `javascriptTag` changes to trigger full page reloads, but
was ignoring `schemaTag` changes that the server was sending.

The fix already existed upstream in v0.0.20+ (commit 4785747) which adds
schemaTag handling. This bumps the dependency from ^0.0.18 to ^0.0.22.

Regression introduced in: 3.88.1
@kdaviduik kdaviduik marked this pull request as ready for review February 10, 2026 07:24
@kdaviduik kdaviduik requested review from a team as code owners February 10, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant