fix: convert file paths to WSL-compatible URLs for profile command #6826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add explicit Writable stream options in ConcurrentOutput for cross-platform compatibility - decodeStrings: false - defaultEncoding: utf8 - highWaterMark: 16 (smaller buffer for faster data flow) - Add buffer: false to execa options in system.ts to disable output buffering - Add debug logging to trace output flow (ui.tsx, ConcurrentOutput.tsx, system.ts) - Add 3 new test cases for delayed writes, rapid consecutive writes, and mixed stdout/stderr Fixes Shopify#6726
Fixes Shopify#5414 When running 'shopify theme profile' in WSL, the generated file URLs (e.g., file:///tmp/speedscope.html) cannot be opened by Windows browsers because they don't understand WSL's Unix paths. This fix: - Adds getWslDistroName() to get the WSL distribution name from environment - Adds convertToWslFileUrl() to convert Unix paths to WSL-compatible format (file://wsl.localhost/<distro>/path) - Updates openProfile() in profile.ts to use these WSL-compatible URLs The fix is transparent for non-WSL environments - paths are converted to standard file:// URLs when not running in WSL.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5414
Problem
When running \shopify theme profile\ in WSL (Windows Subsystem for Linux), the command fails to open the profiler in a browser. The generated file URLs (e.g., \ ile:///tmp/speedscope.html) cannot be accessed by Windows browsers because they don't understand WSL's Unix file paths.
Solution
This PR adds WSL path detection and conversion:
New helper functions in \cli-kit/node/system:
Updated \profile.ts:
The fix is transparent for non-WSL environments - paths are converted to standard \ ile://\ URLs when not running in WSL.
Testing
I commented on the issue offering to help. Please let me know if you'd like any changes to this approach.