Use unified admin store domain for non-1P dev sessions #6824
+36
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dmerand
force-pushed
the
dlm-redirect-app-dev-unified
branch
from
0ceb677 to
e703e55
Compare
5 tasks
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3718 tests passing in 1438 suites. Report generated by 🧪jest coverage report action from e703e55 |
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
dmerand
requested review from
craigmichaelmartin,
gonzaloriestra and
ryancbahan
craigmichaelmartin
approved these changes
Feb 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Updates the app preview URL shown to 3P developers during
shopify app devto use the unified admin URL format instead of the legacy OAuth redirect URL.WHAT is this pull request doing?
Changes the preview URL for 3P developers from the OAuth redirect URL to the unified admin URL format.
Before (original):
appPreviewUrlpreviewURL(shown to user)https://{storeFqdn}/admin/oauth/redirect_from_cli?client_id={apiKey}{proxyUrl}/extensions/dev-consolehttps://{storeFqdn}/admin/oauth/redirect_from_cli?client_id={apiKey}appPreviewUrlhttps://{storeFqdn}/admin/oauth/redirect_from_cli?client_id={apiKey}appPreviewUrlAfter (this PR):
appPreviewUrlpreviewURL(shown to user)https://{storeFqdn}/admin/oauth/redirect_from_cli?client_id={apiKey}{proxyUrl}/extensions/dev-consolehttps://{storeFqdn}/admin/oauth/redirect_from_cli?client_id={apiKey}appPreviewUrlhttps://admin.shopify.com/store/{storeName}/apps/{apiKey}appPreviewUrlThe only change: 3P developers now get the unified admin URL instead of the OAuth redirect URL.
How to test your changes?
shopify app devas a 3P developerhttps://admin.shopify.com/store/{storeName}/apps/{apiKey}shopify app devas a 1P developer (withSHOPIFY_CLI_1P_DEV=1)Measuring impact
How do we know this change was effective? Please choose one:
Checklist