Replace @ethersproject imports with ethers#144
Merged
cgewecke merged 5 commits intoSetProtocol:masterfrom Sep 11, 2021
Merged
Conversation
Motivation in [this comment](SetProtocol#131 (comment)). I expect we'll encounter fewer dependency mismatches for ethers subpackages if we import from the umbrella package. Also the [ethers docs](https://github.com/ethers-io/ethers.js/tree/master/packages/bignumber) say: > Most users will prefer to use the umbrella package, but for those with more specific needs, individual components can be imported.
Contributor
|
Wow!! Will check this out... |
cgewecke
reviewed
Sep 10, 2021
Contributor
cgewecke
left a comment
cgewecke
left a comment
There was a problem hiding this comment.
This is super cool.
The only additional thing to do here is remove the resolutions section in package.json.
Lines 52 to 57 in 59c819c
(Tried this locally and the build was clean) You just need to
- delete the resolutions
- run
rm -rf node_modules - run yarn
...and the yarn lock should update appropriately.
Thanks for the suggestion cgewecke! Agreed these resolutions are no longer necessary. `yarn build` succeeds. - @rootulp
cgewecke
approved these changes
Sep 11, 2021
Contributor
cgewecke
left a comment
cgewecke
left a comment
There was a problem hiding this comment.
Looks great!
(Added a couple additional changes in one test file that uses ethereum-waffle mock contract fixtures)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation in this comment. I expect we'll encounter fewer dependency mismatches for ethers subpackages if we import from the umbrella package. Also the ethers docs say:
Testing
yarn buildsucceeds