Skip to content

Update qwen3.5-bf16-mi325x-sglang SGLang image to v0.5.12-rocm720-mi30x#1429

Merged
functionstackx merged 3 commits into
mainfrom
claude/issue-1154-qwen3.5-bf16-mi325x-sglang
May 17, 2026
Merged

Update qwen3.5-bf16-mi325x-sglang SGLang image to v0.5.12-rocm720-mi30x#1429
functionstackx merged 3 commits into
mainfrom
claude/issue-1154-qwen3.5-bf16-mi325x-sglang

Conversation

@Klaud-Cold
Copy link
Copy Markdown
Collaborator

Updates SGLang image for qwen3.5-bf16-mi325x-sglang from v0.5.10-rocm720-mi30x to v0.5.12-rocm720-mi30x.
\nRef #1154

Generated with Claude Code

Ref #1154

Co-authored-by: Klaud Cold <Klaud-Cold@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow

As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers.

If additional help is needed, PR authors can reach out to core maintainers over Slack.

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow

As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers.

If additional help is needed, PR authors can reach out to core maintainers over Slack.

@github-actions
Copy link
Copy Markdown
Contributor

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow

As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers.

If additional help is needed, PR authors can reach out to core maintainers over Slack.

@github-actions
Copy link
Copy Markdown
Contributor

Comment thread perf-changelog.yaml Outdated
- qwen3.5-bf16-mi325x-sglang
description:
- "Update SGLang image from v0.5.10-rocm720-mi30x to v0.5.12-rocm720-mi30x"
pr-link: XXX
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 The new perf-changelog.yaml entry at line 2556 has pr-link: XXX instead of an actual PR URL. All other entries in this file use the format https://github.com/SemiAnalysisAI/InferenceX/pull/<num>, so this should be replaced with https://github.com/SemiAnalysisAI/InferenceX/pull/1429 before merging.

Extended reasoning...

What the bug is

The diff in perf-changelog.yaml adds a new entry whose pr-link is the literal string XXX:

- config-keys:
    - qwen3.5-bf16-mi325x-sglang
  description:
    - "Update SGLang image from v0.5.10-rocm720-mi30x to v0.5.12-rocm720-mi30x"
  pr-link: XXX

XXX is the documented placeholder that authors use before a PR number is known. Per .github/workflows/claude.yml:224: "Use XXX as the PR-link placeholder until the PR exists." Once the PR exists, the placeholder is supposed to be replaced with the real URL.

Why the existing convention isn't followed

Of the 305 pr-link entries in perf-changelog.yaml, only 2 use XXX: one pre-existing entry at line 2502 and the new entry at line 2556 added by this PR. The 303 other entries — including every recently-added one (lines 2532, 2538, 2544, 2550) — use the full https://github.com/SemiAnalysisAI/InferenceX/pull/<num> URL.

Step-by-step proof

  1. Open perf-changelog.yaml and scroll to line 2556.
  2. Observe the value is the literal string XXX rather than a URL.
  3. Compare against the immediately preceding entry at line 2554, which uses https://github.com/SemiAnalysisAI/InferenceX/pull/1402.
  4. The current PR is Update qwen3.5-bf16-mi325x-sglang SGLang image to v0.5.12-rocm720-mi30x #1429, so the correct value is https://github.com/SemiAnalysisAI/InferenceX/pull/1429.

Impact

This is purely cosmetic — the Pydantic validator only requires pr-link to be a non-empty string, so nothing breaks at runtime. The harm is that the cross-reference back to the merging PR is lost, which makes perf-changelog.yaml less useful as a historical record (the whole point of including pr-link in each entry).

How to fix

Replace pr-link: XXX on line 2556 with:

  pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1429

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

# Conflicts:
#	perf-changelog.yaml
@github-actions
Copy link
Copy Markdown
Contributor

@functionstackx
Copy link
Copy Markdown
Collaborator

/reuse-sweep-run

@functionstackx functionstackx merged commit a936a70 into main May 17, 2026
13 of 19 checks passed
@functionstackx functionstackx deleted the claude/issue-1154-qwen3.5-bf16-mi325x-sglang branch May 17, 2026 08:15
@github-actions
Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

2 participants