std: fix Windows junction_point reparse buffer and rollback#549
Open
SebTardif wants to merge 1 commit into
Open
std: fix Windows junction_point reparse buffer and rollback#549SebTardif wants to merge 1 commit into
SebTardif wants to merge 1 commit into
Conversation
Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This was referenced Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Write the mount-point substitute-name terminating NUL (fix uninit IOCTL input) and roll back the created directory if reparse setup fails.
Problem
PrintNameOffsetreserved a NUL slot after the substitute name but thatu16was never written (MaybeUninitpath buffer, Windows junction_point() passes uninitialized memory as null terminators #263).create_newleft an empty non-junction directory.Change
library/std/src/sys/fs/windows.rsjunction_point: write0u16after substitute name; adjustReparseDataLength; on error drop handle and best-effortrmdir.Origin
d6945f6d8c1Closes #263
Closes #548