Cast enums in lt(), lte(), gt(), gte()#2014
Merged
Merged
Conversation
Member
|
Thank you. Yes, tests are important. I guess the best way is probably for you to add a new table under |
Member
Author
|
Ok, so I tried to add a new table and use it for tests. Then I realized that comparison results depend on the enum's Postgres and SQLite look fine, but I got surprising results for MySQL (see the code comments). If you don't mind, I would like to merge this as is to get Postgres working and create a separate issue for MySQL, which I don't want to dig into at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert 10f3de0, this was discussed under #1527. There weren't any tests for these operators in that initial PR (#258). Let me know if mine can't be merged without adding some. If that's the case, I'm not sure where they should go, bloating
tests::active_enum_tests::insert_active_enumdoesn't feel right.