Skip to content

Fixed LLama.Web error starting session#1158

Merged
martindevans merged 1 commit into
SciSharp:masterfrom
tonib:FixWeb
Apr 17, 2025
Merged

Fixed LLama.Web error starting session#1158
martindevans merged 1 commit into
SciSharp:masterfrom
tonib:FixWeb

Conversation

@tonib

@tonib tonib commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

This should fix #1080

InferenceOptions.SamplingPipeline now is not required. Is not sent from client. This was the main issue for #1080
Added options to debug SignalR calls at appsettings.Development.json. If you dont have this enabled, SignalR serialization errors are not logged (even with Warning level)
Changed default web model to llava-v1.6-mistral-7b.Q3_K_XS.gguf, previous one (llama-2-7b-chat.Q4_0.gguf) did no exist

InferenceOptions.SamplingPipeline now is not required. Is not sent from client
Added options to debug SignalR calls at appsettings.Development.json
Changed default web model to llava-v1.6-mistral-7b.Q3_K_XS.gguf, previous one (llama-2-7b-chat.Q4_0.gguf) did no exist
@martindevans

Copy link
Copy Markdown
Member

Thanks for looking into this

@martindevans martindevans requested a review from Copilot April 15, 2025 12:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • LLama.Web/appsettings.Development.json: Language not supported
  • LLama.Web/appsettings.json: Language not supported

Comment thread LLama.Web/Common/InferenceOptions.cs
@tonib

tonib commented Apr 15, 2025

Copy link
Copy Markdown
Contributor Author

I see LLama.Unittest.Native.SafeLlamaModelHandleTests.MetadataValByKey_ReturnsCorrectly failed.
Strange. I runned tests on my machine (Windows) in Debug/Release and they passed.
It seems MetadataValueByKey() in MetadataValByKey_ReturnsCorrectly returns null, but i did not changed anything related to this

@martindevans

Copy link
Copy Markdown
Member

Yeah I don't think that's your bug. I can't reproduce it locally either though :/

@martindevans

Copy link
Copy Markdown
Member

Even though the CI is failing I'll merge this one, I asked a few other maintainers and we're pretty confident the bug isn't in your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: LLamaSharp Web stopped working

3 participants