Skip to content

681 Exposed people infect others in ABM #689

Merged
xsaschako merged 2 commits intomainfrom
681-exposed-people-infect-others-in-abm
Jul 12, 2023
Merged

681 Exposed people infect others in ABM #689
xsaschako merged 2 commits intomainfrom
681-exposed-people-infect-others-in-abm

Conversation

@xsaschako
Copy link
Copy Markdown
Member

@xsaschako xsaschako commented Jul 11, 2023

Changes

Please briefly list the changes made:

  • Deleted some duplicated code
  • Deleted unnecessary Parameters

Merge Request - GuideLine Checklist

  • Check our git workflow before opening a Pull request/Merge request.
  • Request a reviewer when your work is ready to review, before this please use the draft feature.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes and code coverage is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)

Additional context

Please list additional information or things a reviewer should look out for.

Closes #681 but is subject to change due to #688.

Signed-off-by: Sascha Korf <51127093+xsaschako@users.noreply.github.com>
@xsaschako xsaschako linked an issue Jul 11, 2023 that may be closed by this pull request
2 tasks
@xsaschako xsaschako changed the title fix some duplicated code and erase some params 681 Exposed people infect others in ABM #681 Jul 11, 2023
@xsaschako xsaschako changed the title 681 Exposed people infect others in ABM #681 681 Exposed people infect others in ABM Jul 11, 2023
Comment thread cpp/models/abm/infection.cpp Outdated
@DavidKerkmann DavidKerkmann added class::bug Bugs found in the software class::documentation Improvements or additions to documentation status::in review This issues is in review. loc::backend This issue concerns the C++ backend implementation. model::abm This issue concerns any kind of agent-based model. labels Jul 12, 2023
@DavidKerkmann DavidKerkmann marked this pull request as ready for review July 12, 2023 08:49
Copy link
Copy Markdown
Member

@jubicker jubicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xsaschako xsaschako merged commit 2f70877 into main Jul 12, 2023
@xsaschako xsaschako deleted the 681-exposed-people-infect-others-in-abm branch July 12, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::bug Bugs found in the software class::documentation Improvements or additions to documentation loc::backend This issue concerns the C++ backend implementation. model::abm This issue concerns any kind of agent-based model. status::in review This issues is in review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exposed people infect others in ABM

3 participants