Skip to content

1549 macOS import fails due to incorrect runtime library lookup (RPATH)#1550

Open
HenrZu wants to merge 3 commits intomainfrom
fix-simulation-install-on-MacOS
Open

1549 macOS import fails due to incorrect runtime library lookup (RPATH)#1550
HenrZu wants to merge 3 commits intomainfrom
fix-simulation-install-on-MacOS

Conversation

@HenrZu
Copy link
Copy Markdown
Contributor

@HenrZu HenrZu commented Apr 23, 2026

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Fix build error due to long/unsigned long
  • Fix macOS runtime/import error due to an incorrect RPATH in the Python bindings

If need be, add additional information and what the reviewer should look out for in particular:

  • Im not adding a dedicated macOS CI job as part of this change. We currently don’t have macOS hardware available for validation. This PR fixes the reported macOS-specific build/import issues, but broader macOS CI coverage should be handled separately.

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below).
  • New code adheres to coding guidelines.
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.).
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP).
  • Appropriate documentation within the code (Doxygen) for new functionality has been added in the code.
  • Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation and checked in the preview.
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added.
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed.
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.).
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease).
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.).
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.40%. Comparing base (99275bc) to head (6e3df55).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1550      +/-   ##
==========================================
- Coverage   97.41%   97.40%   -0.02%     
==========================================
  Files         190      190              
  Lines       16858    16866       +8     
==========================================
+ Hits        16422    16428       +6     
- Misses        436      438       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HenrZu HenrZu requested a review from reneSchm April 23, 2026 14:18
Copy link
Copy Markdown
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the big int PickleType's are good, it probably should have been like that from the start.

I am not sure I fully understand the whole rpath situation, the cmake docs mention different variables for windows and apple, but no defaults for CMAKE_INSTALL_RPATH. It is also implied that only Linux uses rpaths at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

memilio-simulation: macOS import fails due to incorrect runtime library lookup (RPATH)

2 participants