bugfix: Correct two return-type annotations #45
Merged
bjjwwang merged 1 commit intoSVF-tools:mainfrom Apr 9, 2026
Merged
Conversation
…traCFGEdge.getCondition()`
Collaborator
|
@mgree Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found two more incorrect annotations in the subts:
CallICFGNode.getCaller()andIntraCFGEdge.getCondition(). (Took the liberty of adding__pycache__to the.gitignore, too... happy to pull that out if you don't want it.)I was going to add a test for this, but realized that the tests in
demoandtest_casesdon't seem to be run in CI anyway. Would you want a PR that adds more API/stub smoketesting? (I see astubtestcall, but I don't think that can detect issues with return values.)Semi-relatedly, would you accept PRs that add other bindings, e.g., to the
AEmodule?