memberOf plugin :: mbof_add_operation() optimizations#8464
Draft
alexey-tikhonov wants to merge 2 commits intoSSSD:masterfrom
Draft
memberOf plugin :: mbof_add_operation() optimizations#8464alexey-tikhonov wants to merge 2 commits intoSSSD:masterfrom
alexey-tikhonov wants to merge 2 commits intoSSSD:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request optimizes the memberof plugin and related group processing functions. The mbof_add_operation function is streamlined by removing a redundant check. More significantly, sdap_add_incomplete_groups is refactored to be more efficient by avoiding a nested loop when checking for missing groups. This simplification propagates to its callers, resulting in cleaner and more performant code for handling group memberships. The changes are well-implemented and improve the codebase.
alexey-tikhonov
force-pushed
the
mbof-add
branch
from
e538934 to
9b17f9b
Compare
'msg->dn' (== 'addop->entry_dn') is already filtered out from 'parents->dns[i]' at the beginning of `mbof_add_operation()`
when removing a duplicate. DNs order doesn't matter.
alexey-tikhonov
force-pushed
the
mbof-add
branch
from
9b17f9b to
e35eab4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.