Merged
Conversation
eakmanrq
approved these changes
Apr 1, 2026
themisvaltinos
approved these changes
Apr 1, 2026
Signed-off-by: George Sittas <giwrgos.sittas@gmail.com>
georgesittas
force-pushed
the
jo/bump_sqlglot_to_30_2_0
branch
from
f9a72b1 to
2ffd03c
Compare
georgesittas
force-pushed
the
jo/bump_sqlglot_to_30_2_0
branch
from
abebd57 to
1c1f32a
Compare
georgesittas
commented
Apr 2, 2026
| assert ( | ||
| kind.merge_filter.sql(dialect=model.dialect) # type: ignore | ||
| == """55 > "__MERGE_SOURCE__"."b" AND "__MERGE_TARGET__"."session_start" > CURRENT_DATE + INTERVAL '7'""" | ||
| == """55 > "__MERGE_SOURCE__"."b" AND "__MERGE_TARGET__"."session_start" > CURRENT_DATE + INTERVAL '7 DAY'""" |
Collaborator
Author
There was a problem hiding this comment.
The previous SQL was incorrect - there was a bug in the postgres dialect for a long time where we would drop the unit. CURRENT_DATE + INTERVAL '7' means add 7 seconds to the current date, whereas the actual filter had "add 7 days to the current date".
I fixed this upstream, hence the bump to v30.2.1.
themisvaltinos
approved these changes
Apr 2, 2026
georgesittas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test Plan
Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO