Skeleton app farhan#60
Draft
FarhanOhe03 wants to merge 17 commits into
Draft
Conversation
tevanburen
requested changes
Mar 12, 2026
Collaborator
tevanburen
left a comment
tevanburen
left a comment
There was a problem hiding this comment.
- Rather than having a helper method, just have doExecute
- Get rid of the javadoc style comments
- Instead of the long switch, have it be an array of answers that you index into
- Remove the CurrentWeather reactor
- Why do you have a change in pnpm-lock?
tevanburen
requested changes
Mar 13, 2026
Collaborator
tevanburen
left a comment
tevanburen
left a comment
There was a problem hiding this comment.
Looking good
- Can we keep the tab size to 2 spaces for consistency
- Let's update the forecasts using copilot so they flow more like english sentences ("The high today is: 75, The low today is: 55, Description: "Pleasant and sunny with a light breeze."" -> "Expect a pleasant and sunny day with a light breeze. The high will reach 75°F and the low will dip to 55°F.")
- " Here is the current conditions for " + city + ": " + forecast + "." is clunky - again, have it flow more naturally
- Let's move the forecast array to the bottom to reduce clutter
Collaborator
|
Nitpicky but can we keep the tab size to 2 for consistency |
tevanburen
reviewed
Mar 16, 2026
| return "The city for which to retrieve the weather information"; | ||
| } | ||
| return null; | ||
| return super.getDescriptionForKey(key); |
Collaborator
There was a problem hiding this comment.
Where are these changes from?
Collaborator
Author
There was a problem hiding this comment.
That change came when I changed from switch to the current string setup we have now. Got the change from copilot just because returning null is less ideal ( what copilot said) but I can revert to that.
you can see where the change happened here.
Collaborator
There was a problem hiding this comment.
Change back to CITY_KEY.equals(key) to avoid a null pointer error
rithvik-doshi
requested changes
Mar 30, 2026
| return "The city for which to retrieve the weather information"; | ||
| } | ||
| return null; | ||
| return super.getDescriptionForKey(key); |
Collaborator
There was a problem hiding this comment.
Change back to CITY_KEY.equals(key) to avoid a null pointer error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes Made
Created a reactor to get current weather from hard coded values.
How to Test
Call the reactor in pixel with city and state
Should return the temperature hard coded with the first letter of the city name as current temperature.
Notes