ml-kem: Update to FIPS 203#47
Merged
Merged
Conversation
Member
|
At some point the documentation (README.md, Cargo.toml) should also be updated to note it's no longer the draft construction |
Member
Contributor
Author
|
@tarcieri - docs and test vectors updated, think this is ready for review |
Contributor
Author
|
I went a little more radical on the test vector refactor than I might have, but honestly (a) the first effort was kinda half-assed, and (b) this way if NIST updates the vectors, we can just pull JSON files and not have to copy/paste a bunch of hex strings. |
Member
|
The JSON files are quite big (831 KB and 558 KB). I think we should either exclude them (and respective tests) from published crates (e.g. see the |
Contributor
Author
|
Good point @newpavlov, added those tests to the exclude list. |
tarcieri
approved these changes
Aug 16, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46
This PR implements the two changes noted in Appendix C of FIPS 203:
It turns out that we had already made the latter change in order to pass the existing test vectors.
Marking as WIP right now because I don't think updated test vectors have been published, and the current code fails on the current test vectors. Should be a quick copy/paste update once the test vectors are available.