fix: forward task configuration through stdin-prompt-stream#11778
Merged
Conversation
daniel-lxs
requested review from
cte,
hannesrudolph,
jr and
mrubens
as code owners
dosubot
bot
added
size:S
The stdin-prompt-stream `start` command only accepted `prompt` — any `configuration` passed via the cloud worker's StartNewTask was silently dropped. This meant custom modes (e.g. `ask-artifacts`), disabled tools, and other task-level settings never reached the extension when running via the CLI harness. Changes: - Add optional `configuration` field to the `start` stdin command - Parse and forward it in `runStdinStreamMode` - Thread it through `ExtensionHost.runTask` → `newTask` webview message → `ClineProvider.createTask` (which already calls `setValues`) - Add `taskConfiguration` field to `WebviewMessage` type Backward-compatible: older CLIs ignore the extra field; older workers that don't send `configuration` trigger no change in behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
daniel-lxs
force-pushed
the
fix/forward-configuration-in-stdin-stream
branch
from
37a746c to
01783ed
Compare
dosubot
bot
added
size:M
Member
Author
|
@mrubens these are the PRs that fix the problem with settings and custom modes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
startcommand only acceptedprompt— anyconfigurationfrom the worker'sStartNewTaskwas silently droppedask-artifacts), disabled tools, and other task-level settings never reached the extensionconfigurationsupport to the protocol and registers custom modes viaupdateCustomMode()so they survive the CustomModesManager's merge cycleChanges (5 files, +30/-8 lines)
packages/types/src/vscode-extension-host.ts: AddtaskConfigurationfield toWebviewMessageapps/cli/src/commands/cli/stdin-stream.ts: Parse optionalconfigurationfromstartcommandapps/cli/src/agent/extension-host.ts: Accept and forwardconfigurationinrunTask()src/core/webview/webviewMessageHandler.ts: PasstaskConfigurationtocreateTask()src/core/webview/ClineProvider.ts: Register custom modes viaupdateCustomMode()increateTask()Backward-compatible: older CLIs ignore the extra JSON field; workers that don't send
configurationtrigger no behavior change.Test plan
Companion PR: https://github.com/RooCodeInc/Roomote/pull/177
🤖 Generated with Claude Code
Interactively review PR in Roo Code Cloud