feat: support AWS Bedrock Application Inference Profiles#11766
Draft
roomote[bot] wants to merge 1 commit intomainfrom
Draft
feat: support AWS Bedrock Application Inference Profiles#11766roomote[bot] wants to merge 1 commit intomainfrom
roomote[bot] wants to merge 1 commit intomainfrom
Conversation
- Add application-inference-profile to parseArn documentation - Add dedicated model info handling for application-inference-profile ARNs in getModelById (assumes modern Claude model defaults) - Add application-inference-profile ARN example in Custom ARN UI - Update ACCESS_DENIED error message to mention application inference profiles and the Custom ARN field - Add test cases for application-inference-profile ARN parsing and model ID handling Addresses #11765
|
I can confirm that this works as expected, it's still a bit weird to have to go to the dropdown list and select "custom arn" and then a new field will appear. I'll leave that to you as a product decision for how you want users to enter custom ARNs. I'm gagged about how easy it was to report the issue and get a solution to be tested. Can't wait to use this in my projects! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #11765
Description
This PR attempts to address Issue #11765 by adding first-class support for AWS Bedrock Application Inference Profiles. Feedback and guidance are welcome.
Changes:
Added
application-inference-profiletoparseArndocumentation (src/api/providers/bedrock.ts): Updated the code comments listing supported ARN types to include Application Inference Profile as a recognized format.Improved model info handling for application inference profiles (
src/api/providers/bedrock.ts): Added a dedicated branch ingetModelByIdforapplication-inference-profilemodel types. Since these profiles use opaque IDs (often UUIDs) that do not reveal the underlying model, the code now provides reasonable defaults (supportsImages: true) assuming the underlying model is likely a modern Claude model.Added
application-inference-profileexample to the UI (webview-ui/src/components/settings/providers/BedrockCustomArn.tsx): Added an example application-inference-profile ARN to the list of format examples shown under the Custom ARN field, so users can see this is a supported format.Updated ACCESS_DENIED error message (
src/api/providers/bedrock.ts): Added a hint about application inference profiles to the error guidance, directing users to enter the full ARN in the "Custom ARN" field rather than the model selector.Added test cases (
src/api/providers/__tests__/bedrock-custom-arn.spec.ts): Added unit tests for application-inference-profile ARN parsing (UUID and alphanumeric profile IDs) and integration test verifying the full ARN is used as the model ID.Test Procedure
npx vitest run api/providers/__tests__/bedrock-custom-arn.spec.tsfromsrc/directory -- all 14 tests passnpx vitest run api/providers/__tests__/bedrock.spec.tsfromsrc/directory -- all 57 tests passPre-Submission Checklist
Documentation Updates
No external documentation updates required. The changes are self-documenting:
Interactively review PR in Roo Code Cloud