Chore: Replace tslint with eslint and improve typing of app#72
Merged
Chore: Replace tslint with eslint and improve typing of app#72
Conversation
Member
KevLehman
commented
Nov 29, 2021
KevLehman
commented
- Replace TSLint (since it's deprecated)
- Added ESLint support for app
- Added Prettier support for app
- Fixed ESLint warnings due to use of and added new type declarations
Contributor
|
Hi, @KevLehman There are a couple of conflicts introduced here due to recent merges...Could you please take a look at them? |
Member
Author
|
Updated. Please check that my resolutions are the right ones 👀 |
murtaza98
reviewed
Nov 30, 2021
murtaza98
reviewed
Nov 30, 2021
murtaza98
reviewed
Nov 30, 2021
murtaza98
reviewed
Nov 30, 2021
murtaza98
reviewed
Nov 30, 2021
- Fix unused variable issues - Avoid using console.error(e)
Contributor
|
Hey, @KevLehman I've included my suggestions within this PR - #73. Please review and merge them here when you get a chance 😄 Thanks for this initiative 💙 |
murtaza98
approved these changes
Dec 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.