Fix Intent Extras in app.service.send#455
Merged
Merged
Conversation
cyberMilosz
requested changes
Jun 8, 2024
Contributor
There was a problem hiding this comment.
Can't we just
i.putExtras(message.getData())instead of extracting all Extras from a Bundle, typecasting them, and handling them one by one?
See:
- https://developer.android.com/reference/android/content/Intent#putExtras(android.os.Bundle)
- https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/content/Intent.java#10937
- https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/os/Bundle.java#301
Assuming you have a test setup for this already - if you don't, shout and I'll try it out.
This was
linked to
issues
Jun 8, 2024
Collaborator
Author
|
confirmed that your code works and already committed your code to my fork go ahead and merge it |
cyberMilosz
approved these changes
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Intent Extras to the Intent which binds a service via
bind()