mobicents-public › org.mobicents.protocols.sctp.AssociationImpl : peerSocketAddress always null

[diamantisk]

Hello group,

Recently i pached JVM source code in order to add support for SCTP to Mac OSX operating systems and this effort succeed.
All thinks worked find but i have to patch org.mobicents.protocols.sctp.AssociationImpl (sctp protocol package) file as follows:

public AssociationImpl(String hostAddress, int hostPort, String peerAddress, int peerPort, String assocName,
IpChannelType ipChannelType, String[] extraHostAddresses) throws IOException {

this();
this.hostAddress = hostAddress;
this.hostPort = hostPort;
this.peerAddress = peerAddress;
this.peerPort = peerPort;
this.name = assocName;
this.ipChannelType = ipChannelType;
this.extraHostAddresses = extraHostAddresses;

// This never initialised, why ?
this.peerSocketAddress = new InetSocketAddress(peerAddress, peerPort);

this.type = AssociationType.CLIENT;

}

Is there any special reason why this.peerSocketAddress isnt initialised anywhere? Having this value as null caused problematic MessageInfo, as a result the native stack returned "Invalid Value" exceptions. With this simple patch, SCTP is working fine even in OSX.

Im asking just to verify if i misunderstood something or not regarding this.peerSocketAddress param.

Greetings

[deruelle]

@vetss can you help comment here ?

[nhanth87]

Can you share your patched JVM @diamantisk

[diamantisk]

Ofcourse, i used it @ OSX El Capitan. It requires the following to be done in advance:

https://github.com/sctplab/SCTP_NKE_ElCapitan (The sources are based on the SCTP implementation of the FreeBSD kernel modified to work within the Mac OS X kernel infrastructure as a network kernel extension. ).

I just made the JVM to be compatible with the above sctp port.

Regarding Restcomm/Sctp project in order to make it work i just added the following line in the library and everything is working as expected.

// This never initialised, why ?
this.peerSocketAddress = new InetSocketAddress(peerAddress, peerPort);

I have uploaed the JDK exported image of the Patched JVM in the following link, as requested:

https://mega.nz/#!pJQxBLiD
(Download key: !oKp6CGm1BbviJCj0E5eg_dW9zqvBm3rH2j2wpFseGts )

[vetss]

Hello @diamantisk

1. For your patch - we can appy it I think, althow this code exists for much time and your addition may beright but I am not very sure.

2. What I suggest to you - use netty version of SCTP lib or at least test it. This version has many advantages so we plan to use netty version further. May be that version will fit your needs and we can skip of updating of nio version.

Please respond if you can test the netty version

[nhanth87]

maybe you are using java 9 and it's not tested by us, we support java 7 at this time

[diamantisk]

Well, i tried with the Netty implementation towards my patched JVM. I faced the same issue as before. This happened because in both cases (using Netty or not), generated MessageInfo object sent to NIO stack always have the address value as null (this was something i tried to fix to the above post by initialising the "this.peerSocketAddress". Doing the same in the Netty version was tricky and i started thinking that it wasnt the correct approach. So i decided to do the following change to my patched JVM: i modified the patched code (the send packet method) to read the peer address, NOT from MessageInfo instance but from the Channel Implementation's instance by getting the defined file descriptor.
To be honest, my patch was based on the source code of JVM (both .java and .c files) from the unix/solaris platform and getting the peer address is done using the MessageInfo object, so i dont know if RestComm/SCTP works in Solaris or not.
After patching the above part as i described, both Netty and non-Netty version of RestComm/SCTP worked as expected.
So im sure now that this issue never was a real issue of RestComm/SCTP but an incompatibility with the original source code of JDK came from solaris/unix (the code i used to make SCTP works for OSX). Anyway, it would be a great chance to test if RestComm/SCTP works as expected in OpenJDK @ Solaris as well.
Thanks for your assistance guys, continue your great job!

[deruelle]

@diamantisk would you mind sharing the modified JDK like you did in #16 (comment) for others benefit if they stumble on the same issue ?

Thanks a lot for reporting back

[diamantisk]

@deruelle i dont know if you remember me but we have met 2 times during MWCs (Barcelona) :-) Yes i will share the modified VM (Both JDL and JRE versions) for OSX. I will upload both versions and i will post the links below.

[diamantisk]

You may find a JRE (JVM) that is able to work with SCTP for OS X (assuming that anyone will follow the SCTP protocol installation for OSX as described at https://github.com/sctplab/SCTP_NKE_ElCapitan) in this url: http://www117.zippyshare.com/v/pWx9qPss/file.html

[deruelle]

@diamantisk from only your github handle and profile I can't figure out your full name but you got me curious now. Can you also sign the CLA at https://telestax.com/open-source/#Contribute for future contributions. This way I'll get your name too and will be able to follow up 😄

Thanks for the publishing of the updated JRE !

[nhanth87]

Hi @diamantisk It may be missed in sctp code, but it also depends on your code :), can you send how you code the sctp application

[nhanth87]

Hi @diamantisk you are using jre 9 and we are not sure it will work correctly (at this time we support java 7). Can you guide me how to make a jdk 7 for mac also, I can hep to check

[diamantisk]

Hi @nhanth87 , yes ofcourse. After @deruelle 's request, i uploaded the source of the JVM in a new repo (https://github.com/diamantisk/openjdk9-sctp), you may find the patched code under jdk.sctp/macosx folter (i also modified the build file accordingly).
This contains also detailed information on how to build the JVM as well!

[guyhhu]

Hello.....How To Get Peet ip and port for sctp