Use ConcurrentHashMap for JVM target#39
Merged
Merged
Conversation
ychescale9
force-pushed
the
yc/concurrent-hash-map-for-jvm
branch
from
May 6, 2023 04:27
0e55e40 to
a490b71
Compare
ychescale9
force-pushed
the
yc/concurrent-hash-map-for-jvm
branch
2 times, most recently
from
May 27, 2023 06:44
b6ca1b1 to
f2e489a
Compare
ychescale9
force-pushed
the
yc/concurrent-hash-map-for-jvm
branch
from
July 6, 2023 10:44
f2e489a to
bfa042f
Compare
This was referenced Feb 23, 2024
ychescale9
force-pushed
the
yc/concurrent-hash-map-for-jvm
branch
from
February 23, 2024 12:01
bfa042f to
76e44e2
Compare
ychescale9
marked this pull request as ready for review
February 23, 2024 12:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#38 attempts to use AndroidX Collection KMP on JVM and iOS (and a few others) for the thread-safe mutable map implementation to address JVM performance issue with Stately.
However both our basic
JvmConcurrencyTestand lincheck surfacedConcurrentModificationExceptionin AndroidX Collection'sSimpleArrayMap.This PR instead use
ConcurrentHashMapfor JVM, and Stately for all other targets.Our
JvmConturrencyTestis passing but Lincheck's Model checking test still surfaces some linearizability issues with ourRealCacheimplementation, though it's not a regression. #47