Add Models and Project for RAT API#6
Merged
DrPaulSharp merged 20 commits intoRascalSoftware:mainfrom Aug 21, 2023
Merged
Conversation
…e all ClassLists have the correct "_class_handle"
StephenNneji
approved these changes
Aug 17, 2023
Contributor
StephenNneji
left a comment
StephenNneji
left a comment
There was a problem hiding this comment.
Looks good, please see comments
| RAT.models.Layer, | ||
| RAT.models.Resolution, | ||
| ]) | ||
| def test_initialise_wrong_classes(model: Callable) -> None: |
Contributor
There was a problem hiding this comment.
is typing the test necessary?
Collaborator
Author
There was a problem hiding this comment.
Maybe not necessary, but helps pycharm with catching errors etc.
41 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.