Constructs python outputs and adds file "run.py"#35
Merged
DrPaulSharp merged 9 commits intoRascalSoftware:mainfrom Jun 11, 2024
Merged
Constructs python outputs and adds file "run.py"#35DrPaulSharp merged 9 commits intoRascalSoftware:mainfrom
DrPaulSharp merged 9 commits intoRascalSoftware:mainfrom
Conversation
StephenNneji
approved these changes
Jun 11, 2024
Contributor
There was a problem hiding this comment.
This file does not contain any tests just fixtures, please rename the file to make it clear. Also I would prefer this data was stored in a pickle file then a script to regenerate and pickle the data was provided instead. otherwise this file would be a pain to update
Collaborator
Author
There was a problem hiding this comment.
"conftest.py" is the name required for pytest discoverability of shared fixtures, see: https://docs.pytest.org/en/6.2.x/fixture.html#conftest-py-sharing-fixtures-across-multiple-files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.