Skip to content

Bug fix for dummy value for qzshifts in "inputs.py" #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DrPaulSharp merged 2 commits into from
May 8, 2024
Merged

Bug fix for dummy value for qzshifts in "inputs.py" #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4c28fb
Updates README.md
DrPaulSharp May 7, 2024
ccc0beb
Bug fix in dummy value for "contrastQzshifts"
DrPaulSharp May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions RAT/inputs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,14 +118,14 @@ def make_problem(project: RAT.Project) -> ProblemDefinition:
problem.params = [param.value for param in project.parameters]
problem.bulkIn = [param.value for param in project.bulk_in]
problem.bulkOut = [param.value for param in project.bulk_out]
problem.qzshifts = []
problem.qzshifts = [0.0]
problem.scalefactors = [param.value for param in project.scalefactors]
problem.domainRatio = [param.value for param in project.domain_ratios]
problem.backgroundParams = [param.value for param in project.background_parameters]
problem.resolutionParams = [param.value for param in project.resolution_parameters]
problem.contrastBulkIns = [project.bulk_in.index(contrast.bulk_in, True) for contrast in project.contrasts]
problem.contrastBulkOuts = [project.bulk_out.index(contrast.bulk_out, True) for contrast in project.contrasts]
problem.contrastQzshifts = [1] * len(project.contrasts) # This is marked as "to do" in RAT
problem.contrastQzshifts = [0] * len(project.contrasts) # This is marked as "to do" in RAT
problem.contrastScalefactors = [project.scalefactors.index(contrast.scalefactor, True) for contrast in project.contrasts]
problem.contrastDomainRatios = [project.domain_ratios.index(contrast.domain_ratio, True)
if hasattr(contrast, 'domain_ratio') else 0 for contrast in project.contrasts]
Expand Down
5 changes: 4 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,14 @@ To install in local directory:
pip install -e .

matlabengine is an optional dependency only required for Matlab custom functions. The version of matlabengine should match the version of Matlab installed on the machine. This can be installed as shown below:

pip install -e .[Matlab-2023a]

Development dependencies can be installed as shown below
Development dependencies can be installed as shown below

pip install -e .[Dev]

To build wheel:

pip install build
python -m build --wheel