added plotting feature using matplotlib #24
Merged
StephenNneji merged 26 commits intoRascalSoftware:mainfrom Apr 26, 2024
Merged
added plotting feature using matplotlib #24StephenNneji merged 26 commits intoRascalSoftware:mainfrom
StephenNneji merged 26 commits intoRascalSoftware:mainfrom
Conversation
RabiyaF
force-pushed
the
port-sld-helper-20
branch
from
0f8b3fa to
78ea824
Compare
RabiyaF
changed the title
Co-authored-by: StephenNneji <34302892+StephenNneji@users.noreply.github.com>
RabiyaF
force-pushed
the
port-sld-helper-20
branch
from
ed8f06e to
87d6571
Compare
Co-authored-by: StephenNneji <34302892+StephenNneji@users.noreply.github.com>
Co-authored-by: StephenNneji <34302892+StephenNneji@users.noreply.github.com>
StephenNneji
approved these changes
Apr 26, 2024
Contributor
StephenNneji
left a comment
StephenNneji
left a comment
There was a problem hiding this comment.
Good Job, thanks for your hard work on this one
41 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20
The PR adds the plotting feature to
Python-RAT. This allows the visualisation of the latest fits of the optimization of the data. The Reflectivity and Scattering Length Density fits are plotted usingMatplotlib. These are comparable to theMATLABplots. This can be seen below by the plots generated using the same data inRATandPython-RAT.Task List
Coverage
Additional Information:
MATLABhandles error bars differently. It automatically removes cases where the data values are negative on a log scale. Additional logic is added to the RATPlots class to remove cases where data - error is negative to display it correctly on the log scale.Plotlyandpyqtgraphwere also explored for the plotting feature. ButMatplotlibgenerated good plots and was faster compared to the other libraries in rendering the updated fits onto the plots window.makeSLDProfileXYis always called with a fixed variablenrepeats = 1inMATLAB. This can probably be removed from the function args in a subsequent refactor.MATLAB Plots (generated using
RAT)Matplotlib Plots (generated using
Python-RAT)