fix: Change default columns to remove total and add amount for expense report view#1
Open
RanuK12 wants to merge 1 commit into
Open
fix: Change default columns to remove total and add amount for expense report view#1RanuK12 wants to merge 1 commit into
RanuK12 wants to merge 1 commit into
Conversation
…e report view [ranukita:2c177a] - Replace TABLE_COLUMNS.TOTAL with TABLE_COLUMNS.TOTAL_AMOUNT in TYPE_DEFAULT_COLUMNS.EXPENSE_REPORT so the inline-editable amount column is shown by default instead of the non-editable total column. - Update the exchange rate logic in getColumnsToShow to add TOTAL (workspace currency) instead of TOTAL_AMOUNT when a conversion exists, since AMOUNT is now the default and TOTAL is the supplementary column. Closes Expensify#93014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Changes the default columns shown in the expense report view to use the inline-editable amount column instead of the non-editable total column.
Fixed Issues
Closes Expensify#93014
Tests
QA Steps
Criterios de aceptación cubiertos
TYPE_DEFAULT_COLUMNS.EXPENSE_REPORTinCONST/index.tsfromTABLE_COLUMNS.TOTALtoTABLE_COLUMNS.TOTAL_AMOUNTgetColumnsToShowinSearchUIUtils.tsto addTABLE_COLUMNS.TOTAL(instead ofTOTAL_AMOUNT) when an exchange rate exists, so both columns are visible when needed