Skip to content

Forward rules and tests for project functions#244

Merged
kshyatt merged 2 commits into
mainfrom
ksh/project_fwd
Jun 5, 2026
Merged

Forward rules and tests for project functions#244
kshyatt merged 2 commits into
mainfrom
ksh/project_fwd

Conversation

@kshyatt

@kshyatt kshyatt commented Jun 4, 2026

Copy link
Copy Markdown
Member

No description provided.

@kshyatt kshyatt requested review from Jutho and lkdvos June 4, 2026 12:47
@codecov

codecov Bot commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
...gebraKitMooncakeExt/MatrixAlgebraKitMooncakeExt.jl 66.06% <100.00%> (+0.82%) ⬆️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos lkdvos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! How would you feel about splitting the testsets into forwards and backwards subsets? I think it might be useful to see which is failing, but this is purely cosmetic

@kshyatt

kshyatt commented Jun 5, 2026 via email

Copy link
Copy Markdown
Member Author

@lkdvos

lkdvos commented Jun 5, 2026

Copy link
Copy Markdown
Member

I was thinking about the @testset split, but maybe it doesn't matter since indeed the line numbers should tell the diagnostics

@kshyatt

kshyatt commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

Enzyme fail unrelated, I think. We really need a way to exclude these AD runs on macos

@kshyatt kshyatt merged commit 183370d into main Jun 5, 2026
34 of 36 checks passed
@kshyatt kshyatt deleted the ksh/project_fwd branch June 5, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants