Forward rules and tests for project functions#244
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
lkdvos
reviewed
Jun 5, 2026
lkdvos
left a comment
Member
There was a problem hiding this comment.
Looks good to me! How would you feel about splitting the testsets into forwards and backwards subsets? I think it might be useful to see which is failing, but this is purely cosmetic
Member
Author
|
For enzyme this is already the case, no? For Mooncake I really don’t have
an opinion, happy to do it if you think it would be clearer
…On Fri, Jun 5, 2026 at 5:15 PM Lukas Devos ***@***.***> wrote:
***@***.**** commented on this pull request.
Looks good to me! How would you feel about splitting the testsets into
forwards and backwards subsets? I think it might be useful to see which is
failing, but this is purely cosmetic
—
Reply to this email directly, view it on GitHub
<#244?email_source=notifications&email_token=AAGKJY5SXQFKXPNE677LWYD46LPZJA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBTG4ZTSNZRGQ32M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4437397147>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGKJY4Z6PEE7S2R7QER25346LPZJAVCNFSM6AAAAACZ2KF2USVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DIMZXGM4TOMJUG4>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AAGKJY7VNAC6A5WI2A3XRWT46LPZJA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBTG4ZTSNZRGQ32M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/AAGKJYZNXKX64DLGRQHG75D46LPZJA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBTG4ZTSNZRGQ32M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
I was thinking about the |
lkdvos
approved these changes
Jun 5, 2026
Member
Author
|
Enzyme fail unrelated, I think. We really need a way to exclude these AD runs on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.