Conversation
![baz-reviewer[bot]](https://avatars.githubusercontent.com/in/933528?s=60&v=4){kind=small}
nest/core/decorators/http_method.py
Outdated
| @@ -1,6 +1,9 @@ | |||
| from typing import Callable, List, Union, TypeVar, ParamSpec, TypeAlias | |||
There was a problem hiding this comment.
❌ Failed check: CLI Test / test (MongoDB)
I’ve attached the relevant part of the log for your convenience:
ImportError: cannot import name 'ParamSpec' from 'typing' module in Python 3.9
Finding type: Log Error
There was a problem hiding this comment.
It looks like this comment has been addressed in commit 58d4b04. The code now checks the Python version and imports ParamSpec from typing_extensions for versions below 3.10, resolving the ImportError for Python 3.9.
nest/core/decorators/http_method.py
Outdated
| @@ -1,6 +1,16 @@ | |||
| from typing import Callable, List, Union, TypeVar, TypeAlias | |||
There was a problem hiding this comment.
❌ Failed check: CLI Test / test (PostgresSync)
I’ve attached the relevant part of the log for your convenience:
ImportError: cannot import name 'TypeAlias' from 'typing' module in Python 3.9
Finding type: Log Error
There was a problem hiding this comment.
It looks like this comment has been addressed. The commit 9de7fce modified the import statement to handle different Python versions, addressing the ImportError for TypeAlias in Python 3.9. The code now conditionally imports TypeAlias from typing_extensions for versions below 3.10, resolving the issue raised in the thread.
nest/core/decorators/http_method.py
Outdated
| @@ -1,6 +1,16 @@ | |||
| from typing import Callable, List, Union, TypeVar, TypeAlias | |||
There was a problem hiding this comment.
❌ Failed check: CLI Test / test (SyncORM)
I’ve attached the relevant part of the log for your convenience:
ImportError: cannot import name 'TypeAlias' from 'typing' module in Python 3.9
Finding type: Log Error
1 participant
User description
Can see the before:
After:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Enhances type hinting across multiple decorator files in the nest/core/decorators directory. Introduces generic type variables and updates function signatures to improve type safety and code clarity. Adds conditional imports for typing features based on Python version compatibility.
Modified files (3)
Latest Contributors(2)
Modified files (7)
Latest Contributors(2)