Skip to content

Include py.typed when packaging.#338

Merged
davidhewitt merged 2 commits into
PyO3:mainfrom
clokep:py-typed
Jun 1, 2023
Merged

Include py.typed when packaging.#338
davidhewitt merged 2 commits into
PyO3:mainfrom
clokep:py-typed

Conversation

@clokep

@clokep clokep commented May 31, 2023

Copy link
Copy Markdown
Contributor

#186 added a py.typed file, but this isn't packaged automatically so other packages (which depend on setuptools-rust) are unable to take advantage of the type hints in it.

I ran python -m build before and after this change:

diff -u <(tar -tf dist/setuptools-rust-1.6.0.tar.gz) <(tar -tf dist-new/setuptools-rust-1.6.0.tar.gz)
--- /dev/fd/11	2023-05-31 09:15:26
+++ /dev/fd/12	2023-05-31 09:15:26
@@ -13,6 +13,7 @@
 setuptools-rust-1.6.0/setuptools_rust/clean.py
 setuptools-rust-1.6.0/setuptools_rust/command.py
 setuptools-rust-1.6.0/setuptools_rust/extension.py
+setuptools-rust-1.6.0/setuptools_rust/py.typed
 setuptools-rust-1.6.0/setuptools_rust/rustc_info.py
 setuptools-rust-1.6.0/setuptools_rust/setuptools_ext.py
 setuptools-rust-1.6.0/setuptools_rust/version.py

@davidhewitt davidhewitt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please add a Packaging CHANGELOG entry?

@clokep

clokep commented May 31, 2023

Copy link
Copy Markdown
Contributor Author

Thanks! Could you please add a Packaging CHANGELOG entry?

Done!

@davidhewitt davidhewitt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@davidhewitt davidhewitt merged commit c5cafcc into PyO3:main Jun 1, 2023
@clokep clokep deleted the py-typed branch June 1, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants