Switch to node-apis, hook up UserClass, fix tests#37
Merged
andrew-propelauth merged 4 commits intomainfrom May 10, 2024
Merged
Conversation
mrmauer
previously requested changes
Apr 8, 2024
Contributor
mrmauer
left a comment
mrmauer
left a comment
There was a problem hiding this comment.
Broadly LGTM, just a few things:
- There's a few places we need to make sure not to let the local yalc dependency sneak into our published source code.
- We should do a gut check that the UserClass from node-apis supports all the same methods (same names) as the UserClass previously defined here. That might just mean more coverage on the unit tests here in a way that may be redundant with tests in node-apis?
itailevi98
force-pushed
the
switch-to-node-apis
branch
from
c69ba9a to
e871641
Compare
Contributor
Author
|
lgtm w/ the new changes |
itailevi98
approved these changes
May 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move shared library and types into the node-apis repo.
This switches to fetch which should work with more environments.
Also hooks up UserClass and adds a new validation function for it.
Then fixes the tests which now need fetch