Skip to content

Remove unused Stop Killing Games popup #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Producdevity merged 2 commits into from
Jun 4, 2026
Merged

Remove unused Stop Killing Games popup #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
192f004
chore: remove unused Stop Killing Games popup
Producdevity Jun 4, 2026
a2c508a
chore: remove unused beta warning popup
Producdevity Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 0 additions & 112 deletions src/components/popups/BetaWarningPopup.tsx
View file
Open in desktop

This file was deleted.

122 changes: 0 additions & 122 deletions src/components/popups/StopKillingGamesPopup.tsx
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/components/popups/index.ts
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions src/data/storageKeys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,7 @@ const storageKeys = {
lastUsedDevice: `${PREFIX}new_listing_last_used_device`,
},
popups: {
stopKillingGamesDismissed: `${PREFIX}stop_killing_games_dismissed`,
voteReminderDismissed: `${PREFIX}vote_reminder_dismissed`,
betaWarningDismissed: `${PREFIX}beta_warning_dismissed_v2`,
supportBannerDismissed: `${PREFIX}support_banner_dismissed`,
},
cookies: {
Expand Down
2 changes: 0 additions & 2 deletions src/lib/analytics/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,10 @@ export const ENGAGEMENT_ACTIONS = {
COMMENT_VOTE_UP: 'comment_vote_up',
GAME_VIEW: 'game_view',
LISTING_VIEW: 'listing_view',
STOP_KILLING_GAMES_CTA: 'stop_killing_games_cta',
USER_PROFILE_VIEW: 'user_profile_view',
VOTE_DOWN: 'vote_down',
VOTE_REMINDER_CLICKED: 'vote_reminder_clicked',
VOTE_REMINDER_DISMISSED: 'vote_reminder_dismissed',
STOP_KILLING_GAMES_DISMISSED: 'stop_killing_games_dismissed',
SUPPORT_BANNER_SHOWN: 'support_banner_shown',
SUPPORT_BANNER_DISMISSED: 'support_banner_dismissed',
SUPPORT_BANNER_CTA: 'support_banner_cta',
Expand Down
18 changes: 0 additions & 18 deletions src/lib/analytics/analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,24 +385,6 @@ const analytics = {
})
},

stopKillingGamesDismissed: (params: { timeOnPage: number }) => {
sendAnalyticsEvent({
category: ANALYTICS_CATEGORIES.ENGAGEMENT,
action: ENGAGEMENT_ACTIONS.STOP_KILLING_GAMES_DISMISSED,
entityType: 'popup',
metadata: { timeOnPage: params.timeOnPage },
})
},

stopKillingGamesCTA: (params: { timeOnPage: number }) => {
sendAnalyticsEvent({
category: ANALYTICS_CATEGORIES.ENGAGEMENT,
action: ENGAGEMENT_ACTIONS.STOP_KILLING_GAMES_CTA,
entityType: 'popup',
metadata: { timeOnPage: params.timeOnPage },
})
},

supportBannerShown: (params: { variant: string; page: string }) => {
sendAnalyticsEvent({
category: ANALYTICS_CATEGORIES.ENGAGEMENT,
Expand Down
Loading