Skip to content

Fix listing new-tab clicks #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Producdevity merged 2 commits into from
May 24, 2026
+490 −284
Merged

Fix listing new-tab clicks #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5eee74
fix(listings): support modifier and middle-click navigation
0xNikilite May 23, 2026
339f069
fix(lint): order generated sql imports
Producdevity May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
289 changes: 158 additions & 131 deletions src/app/listings/ListingsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ import { api } from '@/lib/api'
import { cn } from '@/lib/utils'
import { type RouterInput } from '@/types/trpc'
import { filterNullAndEmpty } from '@/utils/filter'
import {
isAnchorNavigationTarget,
openInNewTab,
shouldOpenInNewTab,
} from '@/utils/navigation-events'
import { roleIncludesRole } from '@/utils/permission-system'
import { hasRolePermission } from '@/utils/permissions'
import { ms } from '@/utils/time'
Expand Down Expand Up @@ -516,149 +521,171 @@ function ListingsPage() {
listingsQuery.isFetching && 'opacity-50',
)}
>
{listingsQuery.data?.listings.map((listing) => (
<tr
key={listing.id}
className="hover:bg-gray-50 dark:hover:bg-gray-700 cursor-pointer transition-colors"
onClick={() => router.push(`/listings/${listing.id}`)}
>
{columnVisibility.isColumnVisible('game') && (
<td className="px-4 py-2 font-medium text-gray-900 dark:text-gray-100">
<div className="flex items-center gap-2">
<Tooltip>
<TooltipTrigger asChild>
<Link
href={`/listings/${listing.id}`}
className="hover:text-blue-600 dark:hover:text-blue-400"
>
{listing.game.title.substring(0, 30)}
{listing.game.title.length > 30 && '...'}
</Link>
</TooltipTrigger>
<TooltipContent side="top">{listing.game.title}</TooltipContent>
</Tooltip>

{listing.status === ApprovalStatus.PENDING && (
{listingsQuery.data?.listings.map((listing) => {
const listingHref = `/listings/${listing.id}`

return (
<tr
key={listing.id}
className="hover:bg-gray-50 dark:hover:bg-gray-700 cursor-pointer transition-colors"
onClick={(event) => {
if (isAnchorNavigationTarget(event)) return

if (shouldOpenInNewTab(event)) {
event.preventDefault()
openInNewTab(listingHref)
return
}

router.push(listingHref)
}}
onAuxClick={(event) => {
if (isAnchorNavigationTarget(event) || !shouldOpenInNewTab(event)) return

event.preventDefault()
openInNewTab(listingHref)
}}
>
{columnVisibility.isColumnVisible('game') && (
<td className="px-4 py-2 font-medium text-gray-900 dark:text-gray-100">
<div className="flex items-center gap-2">
<Tooltip>
<TooltipTrigger>
<Clock className="w-4 h-4 text-amber-600 dark:text-amber-400" />
<TooltipTrigger asChild>
<Link
href={`/listings/${listing.id}`}
className="hover:text-blue-600 dark:hover:text-blue-400"
>
{listing.game.title.substring(0, 30)}
{listing.game.title.length > 30 && '...'}
</Link>
</TooltipTrigger>
<TooltipContent>Under Review</TooltipContent>
<TooltipContent side="top">{listing.game.title}</TooltipContent>
</Tooltip>
)}

<BannedUserBadge
author={listing.author}
canView={isModerator}
label="BANNED"
tooltip="This user has been banned"
/>
{listing.status === ApprovalStatus.PENDING && (
<Tooltip>
<TooltipTrigger>
<Clock className="w-4 h-4 text-amber-600 dark:text-amber-400" />
</TooltipTrigger>
<TooltipContent>Under Review</TooltipContent>
</Tooltip>
)}

<BannedUserBadge
author={listing.author}
canView={isModerator}
label="BANNED"
tooltip="This user has been banned"
/>

{listing.developerVerifications &&
listing.developerVerifications.length > 0 && (
<ListingVerificationBadge
verifications={listing.developerVerifications}
{listing.developerVerifications &&
listing.developerVerifications.length > 0 && (
<ListingVerificationBadge
verifications={listing.developerVerifications}
size="sm"
showTooltip={true}
/>
)}
</div>
</td>
)}
{columnVisibility.isColumnVisible('system') && (
<td className="px-4 py-2 text-gray-700 dark:text-gray-300">
{isSystemIconsHydrated &&
showSystemIcons &&
listing.game.system?.key ? (
<div className="flex items-center gap-2">
<SystemIcon
name={listing.game.system.name}
systemKey={listing.game.system.key}
size="sm"
showTooltip={true}
/>
)}
</div>
</td>
)}
{columnVisibility.isColumnVisible('system') && (
<td className="px-4 py-2 text-gray-700 dark:text-gray-300">
{isSystemIconsHydrated && showSystemIcons && listing.game.system?.key ? (
</div>
) : (
(listing.game.system?.name ?? 'Unknown')
)}
</td>
)}
{columnVisibility.isColumnVisible('device') && (
<td className="px-4 py-2 text-gray-700 dark:text-gray-300">
{listing.device
? `${listing.device.brand.name} ${listing.device.modelName}`
: 'N/A'}
</td>
)}
{columnVisibility.isColumnVisible('emulator') && (
<td className="px-4 py-2 text-gray-700 dark:text-gray-300">
<div className="flex items-center gap-2">
<SystemIcon
name={listing.game.system.name}
systemKey={listing.game.system.key}
size="sm"
/>
{listing.emulator ? (
<EmulatorIcon
name={listing.emulator.name}
logo={listing.emulator.logo}
showLogo={isEmulatorLogosHydrated && showEmulatorLogos}
size="sm"
/>
) : (
'N/A'
)}
{listing.isVerifiedDeveloper && <VerifiedDeveloperBadge size="sm" />}
</div>
) : (
(listing.game.system?.name ?? 'Unknown')
)}
</td>
)}
{columnVisibility.isColumnVisible('device') && (
<td className="px-4 py-2 text-gray-700 dark:text-gray-300">
{listing.device
? `${listing.device.brand.name} ${listing.device.modelName}`
: 'N/A'}
</td>
)}
{columnVisibility.isColumnVisible('emulator') && (
<td className="px-4 py-2 text-gray-700 dark:text-gray-300">
<div className="flex items-center gap-2">
{listing.emulator ? (
<EmulatorIcon
name={listing.emulator.name}
logo={listing.emulator.logo}
showLogo={isEmulatorLogosHydrated && showEmulatorLogos}
size="sm"
/>
</td>
)}
{columnVisibility.isColumnVisible('performance') && (
<td className="px-4 py-2">
<PerformanceBadge
rank={listing.performance?.rank ?? 8}
label={listing.performance?.label ?? 'N/A'}
description={listing.performance?.description}
/>
</td>
)}
{columnVisibility.isColumnVisible('successRate') && (
<td className="px-4 py-2">
<SuccessRateBar
rate={listing.successRate * 100}
voteCount={listing._count.votes}
/>
</td>
)}
{columnVisibility.isColumnVisible('author') && (
<td className="px-4 py-2 text-gray-700 dark:text-gray-300">
{listing.author?.id ? (
<Link
href={`/users/${listing.author.id}`}
className="text-blue-600 dark:text-indigo-400 hover:underline"
onClick={(event) => event.stopPropagation()}
>
{listing.author.name ?? 'Anonymous'}
</Link>
) : (
'N/A'
<span>{listing.author?.name ?? 'Anonymous'}</span>
)}
{listing.isVerifiedDeveloper && <VerifiedDeveloperBadge size="sm" />}
</div>
</td>
)}
{columnVisibility.isColumnVisible('performance') && (
<td className="px-4 py-2">
<PerformanceBadge
rank={listing.performance?.rank ?? 8}
label={listing.performance?.label ?? 'N/A'}
description={listing.performance?.description}
/>
</td>
)}
{columnVisibility.isColumnVisible('successRate') && (
<td className="px-4 py-2">
<SuccessRateBar
rate={listing.successRate * 100}
voteCount={listing._count.votes}
/>
</td>
)}
{columnVisibility.isColumnVisible('author') && (
<td className="px-4 py-2 text-gray-700 dark:text-gray-300">
{listing.author?.id ? (
<Link
href={`/users/${listing.author.id}`}
className="text-blue-600 dark:text-indigo-400 hover:underline"
onClick={(event) => event.stopPropagation()}
>
{listing.author.name ?? 'Anonymous'}
</Link>
) : (
<span>{listing.author?.name ?? 'Anonymous'}</span>
)}
</td>
)}
{columnVisibility.isColumnVisible('posted') && (
<td className="px-4 py-2 text-gray-700 dark:text-gray-300">
<LocalizedDate date={listing.createdAt} format="timeAgo" />
</td>
)}
{columnVisibility.isColumnVisible('actions') && (
<td className="px-6 py-4 text-right" onClick={(e) => e.stopPropagation()}>
<div className="flex items-center justify-end gap-2">
{isAdmin && (
<EditButton
href={`/admin/listings/${listing.id}/edit`}
title="Edit Report"
</td>
)}
{columnVisibility.isColumnVisible('posted') && (
<td className="px-4 py-2 text-gray-700 dark:text-gray-300">
<LocalizedDate date={listing.createdAt} format="timeAgo" />
</td>
)}
{columnVisibility.isColumnVisible('actions') && (
<td className="px-6 py-4 text-right" onClick={(e) => e.stopPropagation()}>
<div className="flex items-center justify-end gap-2">
{isAdmin && (
<EditButton
href={`/admin/listings/${listing.id}/edit`}
title="Edit Report"
/>
)}
<ViewButton
href={`/listings/${listing.id}`}
title="View Report Details"
/>
)}
<ViewButton
href={`/listings/${listing.id}`}
title="View Report Details"
/>
</div>
</td>
)}
</tr>
))}
</div>
</td>
)}
</tr>
)
})}
</tbody>
)}
</table>
Expand Down
Loading
Loading