Combine multiple suppressions applied to the same diagnostic#1699
Merged
rjmholt merged 16 commits intoPowerShell:masterfrom Jul 23, 2021
Merged
Combine multiple suppressions applied to the same diagnostic#1699rjmholt merged 16 commits intoPowerShell:masterfrom
rjmholt merged 16 commits intoPowerShell:masterfrom
Conversation
6 tasks
rjmholt
commented
Jul 21, 2021
|
|
||
| for (int i = 0; i < suppressed.Length; i += 1) | ||
|
|
||
| // Do any error reporting for misused RuleSuppressionIDs here. |
Contributor
Author
There was a problem hiding this comment.
@JamesWTruher elaborated on error reasoning here
This comment has been minimized.
This comment has been minimized.
Contributor
Author
Our preferred style is to use the language aliases over the full type names. For example |
bergmeister
reviewed
Jul 22, 2021
bergmeister
approved these changes
Jul 22, 2021
Collaborator
bergmeister
left a comment
There was a problem hiding this comment.
Looks good from a high level. I agree this PR is probably preferential to the original one.
Contributor
Author
|
Note that suppression attributes didn't seem to work in PSv4 until I made the change in 498a8c9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #1691.
Instead of emitting a suppressed record for each suppression on a diagnostic, we combine all suppressions that apply to a diagnostic into a single object.
This partially reimplements #1694.
/cc @t-lipingma
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.