Skip to content

Upgrade module dependencies#97

Merged
neilcook merged 2 commits into
mainfrom
simpleblob-upgrade
Dec 2, 2025
Merged

Upgrade module dependencies#97
neilcook merged 2 commits into
mainfrom
simpleblob-upgrade

Conversation

@neilcook

@neilcook neilcook commented Dec 1, 2025

Copy link
Copy Markdown
Contributor
  • This involved also fixing several slices.SortFunc functions, because the sort function now returns int not bool

- This involved also fixing several slices.SortFunc functions, because
the sort function now returns int not bool
@neilcook
neilcook requested a review from Luit December 1, 2025 16:13
@Luit

Luit commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

I'd say drop the x/exp dependency and use the standard lib slices. From what I can see that's the same as the new x/exp/slices (SortFunc with int return).

edit: all funcs in x/exp/slices/sort.go just call standard library functions in that version

@neilcook

neilcook commented Dec 2, 2025

Copy link
Copy Markdown
Contributor Author

I'd say drop the x/exp dependency and use the standard lib slices. From what I can see that's the same as the new x/exp/slices (SortFunc with int return).

edit: all funcs in x/exp/slices/sort.go just call standard library functions in that version

Yes good idea

@neilcook
neilcook merged commit 0450684 into main Dec 2, 2025
4 checks passed
@neilcook
neilcook deleted the simpleblob-upgrade branch December 2, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants