Conversation
This allows per-syncer events and hooks.
When generating a DBI dump, keep track of the number of entries added for logging.
Disable the success debug message to reduce log clutter.
We are not actually using the generationID field, but we cannot easily remove it from the filenames. Instead of using a long ID that is now basically zero, simply use "GX" everywhere from now.
Add BlobSize to Update and log extra information when we loaded an update.
The new --only-db allows running LS with only a subset of configured databases for testing.
Add hooks for the existing events to ensure synchronous processing if needed.
nvaatstra
reviewed
May 22, 2025
nvaatstra
left a comment
nvaatstra
left a comment
Contributor
There was a problem hiding this comment.
Looks good, minimal impact to existing processes & code while adding the needed hooks & events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add various hooks for LSE.