fix(yara): triage skill-install scans instead of hard-blocking - #977
Merged
Conversation
downloadSkill scanned installed skills with no triage provider (hardcoded undefined), so any raw YARA match terminated the install with no LLM false-positive pass — our own posthog-best-practices skill got blocked 5x/run on docs like 'you can disable autocapture by setting it to false'. Default the provider from gateway auth (same pass as tool-use scans); still fail-closed when no provider is configured. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Results will be posted here when complete. |
…aged pi never sets the ANTHROPIC_* env vars, so createTriageLLMProvider()'s env fallback is empty on the pi path — scanInstalledSkill ran untriaged there and hard-blocked clean first-party skills. Thread pi's gateway triageAuth through installSkillById -> downloadSkill -> scanInstalledSkill so the pi install_skill tool triages like every other scan path. Non-pi callers pass undefined and keep the env-based default from #977. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
sarahxsanders
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just triage everything i guess