Skip to content

feat(models): add Kimi K3 to Claude adapter - #3869

Merged
trunk-io[bot] merged 1 commit into
mainfrom
posthog-code/add-kimi-k3-model
Jul 28, 2026
Merged

feat(models): add Kimi K3 to Claude adapter#3869
trunk-io[bot] merged 1 commit into
mainfrom
posthog-code/add-kimi-k3-model

Conversation

@tatoalo

@tatoalo tatoalo commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Problem

Kimi K3 🚀

@tatoalo tatoalo self-assigned this Jul 28, 2026
@trunk-io

trunk-io Bot commented Jul 28, 2026

Copy link
Copy Markdown

😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details.

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 82a1d15.

@posthog

posthog Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

👋 Visual changes detected for this PR.

Review and approve in PostHog Visual Review

If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix.

@tatoalo
tatoalo marked this pull request as ready for review July 28, 2026 11:53
Comment thread packages/agent/src/adapters/base-acp-agent.ts
Comment thread packages/ui/src/features/sessions/modelOptionFilters.ts Outdated
@greptile-apps

greptile-apps Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor
Prompt To Fix All With AI
### Issue 1
packages/agent/src/adapters/base-acp-agent.ts:160
**Modal compatibility check drops Kimi**

When gateway model discovery fails or temporarily omits `moonshotai/kimi-k3`, the ID-only compatibility guard does not recognize the newly supported Modal model and replaces it with `claude-opus-4-8`, causing the session to run a different model than the user selected.

### Issue 2
packages/ui/src/features/sessions/modelOptionFilters.ts:43-49
**Hidden Kimi remains selected**

When the Kimi flag is disabled while `moonshotai/kimi-k3` is the current value, this filter removes only the menu option and preserves `currentValue`, so task creation still submits the hidden model and active sessions display its raw ID without a matching selected item.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "chore(models): rename Kimi rollout flag" | Re-trigger Greptile

@tatoalo
tatoalo requested a review from a team July 28, 2026 12:06
Generated-By: PostHog Code
Task-Id: dd739bea-9df5-4e0b-a5e2-42f6b8f8f207
@tatoalo
tatoalo force-pushed the posthog-code/add-kimi-k3-model branch from 9ffcd4a to 82a1d15 Compare July 28, 2026 12:10
@tatoalo tatoalo added the Stamphog This will request an autostamp by stamphog on small changes label Jul 28, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contained, flag-gated feature adding a new model option; both Greptile P1 concerns (Modal ID-fallback recognition, stale currentValue when Kimi is hidden) are directly fixed in the current diff with accompanying unit tests, and the change doesn't touch billing, auth, migrations, dependencies, or CI.

  • Author wrote 0% of the modified lines and has 127 merged PRs in these paths (familiarity MODERATE).
  • 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 147L, 9F substantive, 179L/11F incl. docs/generated/snapshots — within ceiling
tier T1-agent / T1c-medium (179L, 11F, single-area, feat)
stamphog 2.0.0b3 .stamphog/policy.yml @ 9ddb5f3 · reviewed head 82a1d15

@tatoalo tatoalo added the Create Release This will trigger a new release label Jul 28, 2026
@tatoalo
tatoalo enabled auto-merge (squash) July 28, 2026 12:45
@trunk-io
trunk-io Bot merged commit 2a074aa into main Jul 28, 2026
45 checks passed
@trunk-io
trunk-io Bot deleted the posthog-code/add-kimi-k3-model branch July 28, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Create Release This will trigger a new release Stamphog This will request an autostamp by stamphog on small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant