Skip to content

fix(sessions): reuse file Markdown styling for artifacts - #3857

Merged
trunk-io[bot] merged 3 commits into
mainfrom
posthog-code/reuse-markdown-file-preview
Jul 29, 2026
Merged

fix(sessions): reuse file Markdown styling for artifacts#3857
trunk-io[bot] merged 3 commits into
mainfrom
posthog-code/reuse-markdown-file-preview

Conversation

@puemos

@puemos puemos commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Problem

Markdown artifacts use a separate preview style that is less consistent with Markdown files opened from the file explorer.

Why: Keep Markdown documents visually consistent regardless of how they are opened.

Show me!!

Before After
image image

Changes

  • Share the existing file Markdown preview between files and artifacts.
  • Keep HTML artifacts in their sandboxed iframe.

How did you test this?

  • pnpm exec biome check ...
  • pnpm --dir packages/ui exec vitest run src/features/sessions/components/ArtifactPreview.test.tsx
  • pnpm --dir packages/ui typecheck

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Created with PostHog Code

@trunk-io

trunk-io Bot commented Jul 28, 2026

Copy link
Copy Markdown

😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details.

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 15e4e87.

@puemos puemos changed the title Reuse file Markdown styling for artifacts fix(sessions): reuse file Markdown styling for artifacts Jul 28, 2026
@puemos
puemos marked this pull request as ready for review July 28, 2026 05:35
@puemos puemos self-assigned this Jul 28, 2026
@puemos puemos added the reviewhog ($$$) Reviews pull requests before humans do label Jul 28, 2026
@puemos
puemos requested a review from a team July 28, 2026 05:46
@posthog

posthog Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

🦔 ReviewHog reviewed this pull request

Nothing worth raising this time, so here's a calming picture instead:

A happy dog on a sunny path

puemos added 2 commits July 29, 2026 10:12
Generated-By: PostHog Code
Task-Id: ac25b9a6-5db4-4592-ad52-be66ce043db0
Generated-By: PostHog Code
Task-Id: ac25b9a6-5db4-4592-ad52-be66ce043db0
@puemos
puemos force-pushed the posthog-code/reuse-markdown-file-preview branch from 811fdb9 to 467cc83 Compare July 29, 2026 08:12
Generated-By: PostHog Code
Task-Id: ac25b9a6-5db4-4592-ad52-be66ce043db0
@trunk-io
trunk-io Bot merged commit 1157672 into main Jul 29, 2026
32 checks passed
@trunk-io
trunk-io Bot deleted the posthog-code/reuse-markdown-file-preview branch July 29, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewhog ($$$) Reviews pull requests before humans do

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants