Skip to content

fix(loops): resolve creators in my loops - #3852

Merged
trunk-io[bot] merged 1 commit into
mainfrom
posthog-code/fix-loop-creator-label
Jul 27, 2026
Merged

fix(loops): resolve creators in my loops#3852
trunk-io[bot] merged 1 commit into
mainfrom
posthog-code/fix-loop-creator-label

Conversation

@MattPua

@MattPua MattPua commented Jul 27, 2026

Copy link
Copy Markdown
Member

Problem

Team-visible loops owned by the current user appeared under My loops as created by a former organization member.

Changes

  • pass organization member lookup data into rows under My loops
  • cover creator resolution for a current user's team-visible loop

How did you test this?

  • pnpm --filter @posthog/ui test (254 files, 2,187 tests)
  • pnpm --filter @posthog/ui typecheck
  • pnpm exec biome check packages/ui/src/features/loops/components/LoopsListView.tsx packages/ui/src/features/loops/components/LoopsListView.test.tsx
  • commit hook repository-wide typecheck

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Created with PostHog Code

Generated-By: PostHog Code
Task-Id: be1978e3-caac-4a94-aec0-85fd2562beae
@trunk-io

trunk-io Bot commented Jul 27, 2026

Copy link
Copy Markdown

😎 Merged successfully - details.

@MattPua MattPua added the Stamphog This will request an autostamp by stamphog on small changes label Jul 27, 2026
@github-actions

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit c7f45d8.

@MattPua
MattPua marked this pull request as ready for review July 27, 2026 19:45
@greptile-apps

greptile-apps Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "fix(loops): resolve creators in my loops" | Re-trigger Greptile

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small, well-tested UI fix threading member lookup data to fix creator display for team-visible loops; no risky territory touched and author has strong familiarity with this code.

  • Author wrote 100% of the modified lines and has 9 merged PRs in these paths (familiarity STRONG).
  • 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 8L, 1F substantive, 32L/2F incl. docs/generated/snapshots — within ceiling
tier T1-agent / T1b-small (32L, 2F, single-area, fix)
stamphog 2.0.0b3 .stamphog/policy.yml @ d723199 · reviewed head c7f45d8

@trunk-io
trunk-io Bot merged commit 23c5236 into main Jul 27, 2026
41 checks passed
@trunk-io
trunk-io Bot deleted the posthog-code/fix-loop-creator-label branch July 27, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stamphog This will request an autostamp by stamphog on small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant