feat(loops): edit loop details inline - #3848
Conversation
Generated-By: PostHog Code Task-Id: c163b9ac-f496-4ea0-9412-c48cf357eab0
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found 9 issues in 2 files · 9 warnings. 9 warnings
Reviewed by React Doctor for commit |
Generated-By: PostHog Code Task-Id: c163b9ac-f496-4ea0-9412-c48cf357eab0
Generated-By: PostHog Code Task-Id: c163b9ac-f496-4ea0-9412-c48cf357eab0
Generated-By: PostHog Code Task-Id: c163b9ac-f496-4ea0-9412-c48cf357eab0
Generated-By: PostHog Code Task-Id: c163b9ac-f496-4ea0-9412-c48cf357eab0
Generated-By: PostHog Code Task-Id: c163b9ac-f496-4ea0-9412-c48cf357eab0
Prompt To Fix All With AIFix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
packages/ui/src/features/loops/components/LoopDetailView.tsx:489-498
**Model edits create schedules**
When a loop has no schedule and the user changes only its model configuration, the synthetic enabled schedule draft is unconditionally appended to the update payload, causing the loop to begin running automatically on the default schedule.
### Issue 2 of 2
packages/ui/src/features/loops/components/LoopDetailView.tsx:416-421
**Loop updates leave stale drafts**
When the queried loop changes while this view remains mounted, these states retain the previous configuration; `hasChanges` then compares stale drafts with the latest loop and saving writes the stale model and schedule values back, overwriting newer configuration.
Reviews (1): Last reviewed commit: "fix: clarify loop agent selector label" | Re-trigger Greptile |
Generated-By: PostHog Code Task-Id: 04bf4629-bd34-4c53-bdde-acd162d6b045
Generated-By: PostHog Code Task-Id: 04bf4629-bd34-4c53-bdde-acd162d6b045
|
Does this work with GitHub triggers and the other options? Maybe we should just prompt that same wizard view and make it a shared dialog and just have an edit button. |
Generated-By: PostHog Code Task-Id: 04bf4629-bd34-4c53-bdde-acd162d6b045
do you mean like show the wizard view as a modal vs the inline? i havent checked the other triggers yet, selfishly only looked at the stuff i needed |
Generated-By: PostHog Code Task-Id: 04bf4629-bd34-4c53-bdde-acd162d6b045
Problem
Editing loop metadata, schedules, or model configuration requires navigating to the full edit flow.
Changes
How did you test this?
Automatic notifications
Created with PostHog Code