Skip to content

fix(loops): Remove empty state CTA buttons - #3845

Merged
charlesvien merged 1 commit into
mainfrom
fix/loops-remove-empty-state-ctas
Jul 27, 2026
Merged

fix(loops): Remove empty state CTA buttons#3845
charlesvien merged 1 commit into
mainfrom
fix/loops-remove-empty-state-ctas

Conversation

@charlesvien

Copy link
Copy Markdown
Member

Problem

The loops empty state has a "Learn more" button pointing at https://posthog.com/docs/loops, which does not exist, and a "Create a loop" button that duplicates the create entry points already on the page.

Changes

Removed both buttons from LoopsEmptyState so the card is just the illustration, heading and getting-started steps. Dropped the now unused onCreate and disabledReason props from the component and its call sites in LoopsListView and WebsiteChannelLoops.

How did you test this?

Updated the LoopsEmptyState unit tests and ran them, plus Biome and turbo typecheck --filter=@posthog/ui.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

@trunk-io

trunk-io Bot commented Jul 27, 2026

Copy link
Copy Markdown

😎 This pull request was merged.

@charlesvien charlesvien added the Stamphog This will request an autostamp by stamphog on small changes label Jul 27, 2026
@github-actions

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit c2bff20.

@charlesvien
charlesvien enabled auto-merge (squash) July 27, 2026 15:36
@greptile-apps

greptile-apps Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "remove loops empty state CTA buttons" | Re-trigger Greptile

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward, well-contained removal of dead/broken CTA buttons from an empty-state component, with props cleaned up consistently across all call sites and tests updated to match; no risky territory touched and no outstanding concerns.

  • Author wrote 13% of the modified lines and has 15 merged PRs in these paths (familiarity MODERATE).
  • 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 59L, 3F substantive, 104L/4F incl. docs/generated/snapshots — within ceiling
tier T1-agent / T1c-medium (104L, 4F, single-area, fix)
stamphog 2.0.0b3 .stamphog/policy.yml @ 113eae9 · reviewed head c2bff20

@charlesvien
charlesvien disabled auto-merge July 27, 2026 15:50
@charlesvien
charlesvien merged commit a8396c6 into main Jul 27, 2026
34 checks passed
@charlesvien
charlesvien deleted the fix/loops-remove-empty-state-ctas branch July 27, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stamphog This will request an autostamp by stamphog on small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant