fix(loops): Remove empty state CTA buttons - #3845
Merged
Merged
Conversation
|
😎 This pull request was merged. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
charlesvien
enabled auto-merge (squash)
July 27, 2026 15:36
Contributor
|
Reviews (1): Last reviewed commit: "remove loops empty state CTA buttons" | Re-trigger Greptile |
There was a problem hiding this comment.
Straightforward, well-contained removal of dead/broken CTA buttons from an empty-state component, with props cleaned up consistently across all call sites and tests updated to match; no risky territory touched and no outstanding concerns.
- Author wrote 13% of the modified lines and has 15 merged PRs in these paths (familiarity MODERATE).
- 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 59L, 3F substantive, 104L/4F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1c-medium (104L, 4F, single-area, fix) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ 113eae9 · reviewed head c2bff20 |
charlesvien
disabled auto-merge
July 27, 2026 15:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The loops empty state has a "Learn more" button pointing at https://posthog.com/docs/loops, which does not exist, and a "Create a loop" button that duplicates the create entry points already on the page.
Changes
Removed both buttons from
LoopsEmptyStateso the card is just the illustration, heading and getting-started steps. Dropped the now unusedonCreateanddisabledReasonprops from the component and its call sites inLoopsListViewandWebsiteChannelLoops.How did you test this?
Updated the
LoopsEmptyStateunit tests and ran them, plus Biome andturbo typecheck --filter=@posthog/ui.Automatic notifications