fix(git): record every PR created for a local task by frankh · Pull Request #3840 · PostHog/code

frankh · 2026-07-27T13:36:33Z

Problem

On a local (desktop worktree) task that produced two PRs, the task header shows only one PR badge (the latest / current branch) with no "Other PRs" submenu. Multi‑PR‑per‑task support exists (#3227) via a pr_urls array, but for local tasks nothing recorded a PR at creation time.

pr_urls was only populated as a side effect of polling getPrStatus on the currently checked‑out branch during revalidation. So if the agent opens PR #1 on branch A, then continues and opens PR #2 on branch B before any revalidation fires while A is current, PR #1 is never recorded — only PR #2 survives, and there's nothing to populate the submenu.

Fix

Event‑driven capture (primary). The Create‑PR saga now accumulates the created PR URL the moment the PR is made, independent of which branch is later checked out — mirroring how cloud already works. New accumulatePrUrl seam: CreatePrHost → GitWorkspaceLookup → IGitPrStatus → TaskPrStatusService.accumulatePrUrl (does updatePrCache(..., accumulate: true) + emits taskPrInfoChanged), wired in the composition root. No schema change — the pr_urls column already exists. Array order is preserved, so promote‑to‑primary and dedupe still hold.
Local agent hardening. attachPrIfCreatedThisRun enforced the author match unconditionally, so a genuinely agent‑created PR was silently dropped whenever gh api user returned no login. Now the author check applies only when a login actually resolved (matching agent-server.ts); the 5‑minute recency gate still scopes attribution.

Tests

New TaskPrStatusService.accumulatePrUrl suite: first PR sets primary + pr_urls=[A]; second distinct PR yields [A,B]; re‑accumulating A is idempotent; no‑op when the task has no workspace row.
Saga test asserts accumulatePrUrl is called on success.
Explicit resolveTaskPrUrls regression case for two accumulated local PRs surfacing an "Other PRs" entry.

Verification

Typecheck: @posthog/core, @posthog/workspace-server, @posthog/host-router, apps/code — clean.
Tests: core (2503), ui (2164), task-pr-status (12) — pass.
Lint clean, zero noRestrictedImports in packages/core; no new host‑boundary violations.

Created with PostHog Code

Local tasks only ever accumulated the PR on the currently checked-out branch, as a side effect of polling getPrStatus during revalidation. A task that opened a second PR on a new branch lost the first one, so the header showed a single PR with no "Other PRs" submenu. Capture the PR at creation time instead: the Create-PR saga now accumulates the created URL through a new accumulatePrUrl seam (CreatePrHost -> GitWorkspaceLookup -> IGitPrStatus -> TaskPrStatusService), independent of which branch is later checked out. Also stop the local agent PR-attribution path from dropping a genuinely-created PR when `gh api user` resolves no login, matching agent-server. Generated-By: PostHog Code Task-Id: 2973f063-1e37-44ea-8d96-3e22a28e10a7

trunk-io · 2026-07-27T13:36:37Z

Merging to main in this repository is managed by Trunk.

To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

github-actions · 2026-07-27T13:37:04Z

React Doctor found no issues in the changed files. 🎉

_{Reviewed by React Doctor for commit 3fcc7b0.}

veria-ai · 2026-07-27T13:38:16Z

PR overview

All previously flagged issues have been addressed. No open security concerns remain on this pull request.

Security review

No open security issues remain on this pull request.

Fixed/addressed: 1 · PR risk: 0/10

greptile-apps · 2026-07-27T13:39:24Z

Prompt To Fix All With AI

Fix the following 3 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 3
packages/workspace-server/src/services/git/task-pr-status.ts:74-76
**PR creation order is lost**

When two PRs are created for the same task before either details lookup finishes, their URLs are appended in lookup-completion order rather than creation order. Since the UI treats `prUrls[0]` as primary, the second-created PR is displayed as the primary badge when its lookup resolves first.

### Issue 2 of 3
packages/workspace-server/src/services/agent/agent.ts:2231
**Missing login bypasses attribution**

When `gh api user` transiently fails, any PR created within the five-minute window and present in agent output passes this guard without an author or repository match. This attaches an unrelated recent PR to the task and links the current branch as though the PR were created during this run, producing incorrect PR badge and branch state.

### Issue 3 of 3
apps/code/src/main/di/container.ts:587-591
**PR persistence is fire-and-forget**

When the app shuts down after PR creation while `getPrDetailsByUrl` is still pending, this discarded promise reaches the closed database and rejects without being handled. The create-PR flow has already reported success, but the new PR URL is never persisted and disappears from the task after restart.

_{Reviews (1): Last reviewed commit: "fix(git): record every PR created for a ..." | Re-trigger Greptile}

greptile-apps · 2026-07-27T13:39:28Z

+    const details = await this.gitService
+      .getPrDetailsByUrl(prUrl)
+      .catch(() => null);


PR creation order is lost

When two PRs are created for the same task before either details lookup finishes, their URLs are appended in lookup-completion order rather than creation order. Since the UI treats prUrls[0] as primary, the second-created PR is displayed as the primary badge when its lookup resolves first.

Knowledge Base Used: workspace-server

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/workspace-server/src/services/git/task-pr-status.ts Line: 74-76 Comment: **PR creation order is lost** When two PRs are created for the same task before either details lookup finishes, their URLs are appended in lookup-completion order rather than creation order. Since the UI treats `prUrls[0]` as primary, the second-created PR is displayed as the primary badge when its lookup resolves first. **Knowledge Base Used:** [workspace-server](https://app.greptile.com/posthog-org-19734/-/custom-context/knowledge-base/posthog/code/-/docs/workspace-server.md) How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-07-27T13:39:29Z

    ]);
    if (!wasCreatedRecently(attribution.createdAt, Date.now())) return;
-    if (!wasCreatedByLogin(attribution.author, ghLogin)) return;
+    if (ghLogin && !wasCreatedByLogin(attribution.author, ghLogin)) return;


Missing login bypasses attribution

When gh api user transiently fails, any PR created within the five-minute window and present in agent output passes this guard without an author or repository match. This attaches an unrelated recent PR to the task and links the current branch as though the PR were created during this run, producing incorrect PR badge and branch state.

Rule Used: When implementing new features, ensure that owners... (source)

Learned From
PostHog/posthog#31236

Knowledge Base Used: workspace-server

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/workspace-server/src/services/agent/agent.ts Line: 2231 Comment: **Missing login bypasses attribution** When `gh api user` transiently fails, any PR created within the five-minute window and present in agent output passes this guard without an author or repository match. This attaches an unrelated recent PR to the task and links the current branch as though the PR were created during this run, producing incorrect PR badge and branch state. **Rule Used:** When implementing new features, ensure that owners... ([source](https://app.greptile.com/posthog-org-19734/-/custom-context?memory=9655b466-451a-401a-9ba0-5bf3e7b7f9f8)) **Learned From** [PostHog/posthog#31236](https://github.com/PostHog/posthog/pull/31236) **Knowledge Base Used:** [workspace-server](https://app.greptile.com/posthog-org-19734/-/custom-context/knowledge-base/posthog/code/-/docs/workspace-server.md) How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-07-27T13:39:30Z

+      accumulatePrUrl: (taskId, prUrl) => {
+        void ctx
+          .get<IGitPrStatus>(GIT_PR_STATUS_PROVIDER)
+          .accumulatePrUrl(taskId, prUrl);
+      },


PR persistence is fire-and-forget

When the app shuts down after PR creation while getPrDetailsByUrl is still pending, this discarded promise reaches the closed database and rejects without being handled. The create-PR flow has already reported success, but the new PR URL is never persisted and disappears from the task after restart.

Rule Used: Always wrap asynchronous calls that may fail, such... (source)

Learned From
PostHog/posthog#32098

Knowledge Base Used:

PostHog Code Desktop App (apps/code)

workspace-server

Prompt To Fix With AI

This is a comment left during a code review. Path: apps/code/src/main/di/container.ts Line: 587-591 Comment: **PR persistence is fire-and-forget** When the app shuts down after PR creation while `getPrDetailsByUrl` is still pending, this discarded promise reaches the closed database and rejects without being handled. The create-PR flow has already reported success, but the new PR URL is never persisted and disappears from the task after restart. **Rule Used:** Always wrap asynchronous calls that may fail, such... ([source](https://app.greptile.com/posthog-org-19734/-/custom-context?memory=df81f021-48c3-45e4-981f-7348133f5f7a)) **Learned From** [PostHog/posthog#32098](https://github.com/PostHog/posthog/pull/32098) **Knowledge Base Used:** - [PostHog Code Desktop App (`apps/code`)](https://app.greptile.com/posthog-org-19734/-/custom-context/knowledge-base/posthog/code/-/docs/apps-code-desktop.md) - [workspace-server](https://app.greptile.com/posthog-org-19734/-/custom-context/knowledge-base/posthog/code/-/docs/workspace-server.md) How can I resolve this? If you propose a fix, please make it concise.

Co-authored-by: veria-ai[bot] <224490171+veria-ai[bot]@users.noreply.github.com>

…l-task-multiple-prs

…:posthog/code into posthog-code/fix-local-task-multiple-prs

Restores `if (ghLogin && !wasCreatedByLogin(...))`, undoing the veria-ai suggestion (a4e5cf8) that dropped the `ghLogin &&` condition. The unconditional form is exactly what broke bot/signal PR attribution in #3227: when `gh api user` resolves no login (App tokens, impersonated sessions), wasCreatedByLogin returns false and every genuinely run-created PR is discarded. Mirrors the cloud path fixed in #3302. Generated-By: PostHog Code Task-Id: 2973f063-1e37-44ea-8d96-3e22a28e10a7

veria-ai Bot reviewed Jul 27, 2026

View reviewed changes

Comment thread packages/workspace-server/src/services/agent/agent.ts

greptile-apps Bot reviewed Jul 27, 2026

View reviewed changes

frankh and others added 4 commits July 27, 2026 15:44

Update packages/workspace-server/src/services/agent/agent.ts

a4e5cf8

Co-authored-by: veria-ai[bot] <224490171+veria-ai[bot]@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into posthog-code/fix-loca…

338cd6d

…l-task-multiple-prs

Merge branch 'posthog-code/fix-local-task-multiple-prs' of github.com…

13240e4

…:posthog/code into posthog-code/fix-local-task-multiple-prs

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(git): record every PR created for a local task - #3840

fix(git): record every PR created for a local task#3840
frankh wants to merge 5 commits into
mainfrom
posthog-code/fix-local-task-multiple-prs

frankh commented Jul 27, 2026

Uh oh!

trunk-io Bot commented Jul 27, 2026

Uh oh!

github-actions Bot commented Jul 27, 2026 •

edited

Loading

Uh oh!

Uh oh!

veria-ai Bot commented Jul 27, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Jul 27, 2026

Uh oh!

greptile-apps Bot Jul 27, 2026

Uh oh!

greptile-apps Bot Jul 27, 2026

Uh oh!

greptile-apps Bot Jul 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

frankh commented Jul 27, 2026

Problem

Fix

Tests

Verification

Uh oh!

trunk-io Bot commented Jul 27, 2026

Uh oh!

github-actions Bot commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

veria-ai Bot commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR overview

Security review

Uh oh!

greptile-apps Bot commented Jul 27, 2026

Uh oh!

greptile-apps Bot Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions Bot commented Jul 27, 2026 •

edited

Loading

veria-ai Bot commented Jul 27, 2026 •

edited

Loading