Skip to content

fix(loops): Tighten space above the loop list tabs - #3830

Merged
charlesvien merged 2 commits into
mainfrom
fix/loops-list-tab-spacing
Jul 27, 2026
Merged

fix(loops): Tighten space above the loop list tabs#3830
charlesvien merged 2 commits into
mainfrom
fix/loops-list-tab-spacing

Conversation

@charlesvien

Copy link
Copy Markdown
Member

Problem

The loops page had ~40px of dead space between the page description and the "My loops / Team loops" tabs: the page column's 32px section gap stacked with the tab triggers' own top padding.

Changes

Grouped the header and the loop list area (tabs, skeleton, error and empty states) into one column with a 16px gap. The templates section keeps its 32px separation.

How did you test this?

@posthog/ui typecheck and the full UI unit suite (2162 tests) pass.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

@trunk-io

trunk-io Bot commented Jul 27, 2026

Copy link
Copy Markdown

😎 This pull request was merged.

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 0f491e0.

@greptile-apps

greptile-apps Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "tighten space above loops list tabs" | Re-trigger Greptile

@charlesvien charlesvien added the Stamphog This will request an autostamp by stamphog on small changes label Jul 27, 2026
@posthog

posthog Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Visual changes approved by @charlesvien — baseline updated in 0f491e0.

View this run in PostHog

6 changed.

github-actions[bot]
github-actions Bot previously approved these changes Jul 27, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pure layout/spacing refactor in a UI presentation component, matches the PR description exactly, no logic or risky-territory changes.

  • Author wrote 66% of the modified lines and has 13 merged PRs in these paths (familiarity MODERATE).
  • 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 126L, 1F substantive — within ceiling
tier T1-agent / T1c-medium (126L, 1F, single-area, fix)
stamphog 2.0.0b3 .stamphog/policy.yml @ c531d06 · reviewed head 7ced7f5

6 updated
Run: a8434020-f0d2-420f-8abd-894e33042fe0

Co-authored-by: charlesvien <5378415+charlesvien@users.noreply.github.com>
@stamphog
stamphog Bot dismissed github-actions[bot]’s stale review July 27, 2026 06:50

New commits pushed (delta classified non_trivial_delta) — stamphog approval dismissed; re-review running automatically.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Purely cosmetic layout change (regrouping flex containers to tighten spacing) with matching snapshot updates already visually approved; no risky territory touched and no outstanding concerns.

  • Author wrote 62% of the modified lines and has 162 merged PRs in these paths (familiarity MODERATE).
  • 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 138L, 2F substantive — within ceiling
tier T1-agent / T1c-medium (138L, 2F, two-areas, fix)
stamphog 2.0.0b3 .stamphog/policy.yml @ c531d06 · reviewed head 0f491e0

@charlesvien
charlesvien merged commit 1f174f1 into main Jul 27, 2026
31 checks passed
@charlesvien
charlesvien deleted the fix/loops-list-tab-spacing branch July 27, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stamphog This will request an autostamp by stamphog on small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant