Move Channels switch into the task panel header - #3822
Merged
trunk-io[bot] merged 6 commits intoJul 26, 2026
Conversation
Generated-By: PostHog Code Task-Id: 0c011a69-42cd-47b7-ad39-634de03b9cb8
|
😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Generated-By: PostHog Code Task-Id: 0c011a69-42cd-47b7-ad39-634de03b9cb8
Generated-By: PostHog Code Task-Id: 0c011a69-42cd-47b7-ad39-634de03b9cb8
Generated-By: PostHog Code Task-Id: 0c011a69-42cd-47b7-ad39-634de03b9cb8
Generated-By: PostHog Code Task-Id: 0c011a69-42cd-47b7-ad39-634de03b9cb8
k11kirky
marked this pull request as ready for review
July 26, 2026 05:52
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
packages/ui/src/features/sidebar/constants.ts:6-12
**Persisted orders bypass Activity placement**
When an existing user has a non-empty persisted `navItemOrder`, `orderedNavItems` retains Activity's stored position instead of applying this new default, causing Activity to remain after Command Center or elsewhere rather than directly below Inbox.
Reviews (1): Last reviewed commit: "Increase sidebar mode label size" | Re-trigger Greptile |
Generated-By: PostHog Code Task-Id: 0c011a69-42cd-47b7-ad39-634de03b9cb8
adamleithp
approved these changes
Jul 26, 2026
There was a problem hiding this comment.
Contained UI-only sidebar refactor with no risky-territory surface touched; the one substantive reviewer concern (Activity ordering with persisted nav state) is directly fixed in constants.ts with new test coverage, and a teammate approved the current head.
- Author wrote 5% of the modified lines and has 18 merged PRs in these paths (familiarity MODERATE).
- adamleithp reviewed the current head.
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 196L, 7F substantive, 376L/11F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1d-complex (376L, 11F, single-area, unknown) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ cee8b0e · reviewed head 44efe8f |
Contributor
Author
|
/trunk merge |
trunk-io
Bot
deleted the
posthog-code/move-channels-switch-to-panel-header
branch
July 26, 2026 06:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Channels mode control occupies a global navigation row even though it changes the contents of the task panel. Moving the control into that panel makes its scope clearer and keeps mode-specific actions beside the content they affect.
Changes
mode.switcher.mov
How did you test this?
pnpm --filter @posthog/ui typecheckpnpm --dir packages/ui exec vitest run src/features/sidebar/components/SidebarNavSection.test.tsx src/features/sidebar/components/TasksHeader.test.tsx src/features/sidebar/components/CustomizeSidebarDialog.test.tsxpnpm exec biome check packages/ui/src/features/canvas/components/ChannelsSidebar.tsx packages/ui/src/features/sidebarAutomatic notifications
Created with PostHog Code