Skip to content

refactor(canvas): share thread and PR artifact logic (1/4) - #3812

Merged
trunk-io[bot] merged 2 commits into
mainfrom
posthog-code/channels-stack-1-activity-refactors
Jul 28, 2026
Merged

refactor(canvas): share thread and PR artifact logic (1/4)#3812
trunk-io[bot] merged 2 commits into
mainfrom
posthog-code/channels-stack-1-activity-refactors

Conversation

@puemos

@puemos puemos commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Problem

Task thread behavior and pull request artifact rendering were duplicated across channel surfaces, making the upcoming Activity view harder to review and easier to drift.

Changes

  • Extract shared thread conversation behavior and PR artifact presentation.
  • Adopt both helpers in the existing Thread panel and channel artifacts view.
  • No new layout or flag-gated experience is activated in this PR.

This is PR 1 of the channel spaces stack and is safe with the layout flag either off or on: both states retain the existing experience.

How did you test this?

  • pnpm exec vitest run src/features/canvas/components/ThreadPanel.test.tsx src/utils/posthogLinks.test.ts
  • pnpm typecheck in packages/ui

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Created with PostHog Code

@trunk-io

trunk-io Bot commented Jul 25, 2026

Copy link
Copy Markdown

😎 Merged successfully - details.

@github-actions

github-actions Bot commented Jul 25, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit e04e1a2.

puemos commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

@puemos
puemos marked this pull request as ready for review July 27, 2026 07:07
@puemos puemos added the reviewhog ($$$) Reviews pull requests before humans do label Jul 27, 2026 — with Graphite App
@puemos
puemos requested a review from k11kirky July 27, 2026 07:08
@puemos puemos self-assigned this Jul 27, 2026
@puemos puemos changed the title refactor(canvas): share thread and PR artifact logic refactor(canvas): share thread and PR artifact logic (1/4) Jul 27, 2026
puemos added 2 commits July 27, 2026 20:44
Extract the task thread conversation behavior and PR artifact presentation used by existing channel surfaces. This is behavior-neutral groundwork for the structured Activity view.

Generated-By: PostHog Code
Task-Id: 6190e713-9b80-43d9-a05c-5e3b1ecdf297
Generated-By: PostHog Code
Task-Id: 6190e713-9b80-43d9-a05c-5e3b1ecdf297
@puemos
puemos force-pushed the posthog-code/channels-stack-1-activity-refactors branch from 0b813d4 to e04e1a2 Compare July 27, 2026 18:44

puemos commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jul 28, 8:32 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 28, 8:52 AM UTC: Graphite couldn't merge this PR because it failed for an unknown reason (GitHub is reporting that this PR is not mergeable, despite passing required status checks defined by your branch protection rules. Please check your rulesets for additional blocking criteria. Graphite Merge Queue does not currently support rulesets. Please contact Graphite support for further assistance.).

@trunk-io
trunk-io Bot merged commit 621b6da into main Jul 28, 2026
35 checks passed
@trunk-io
trunk-io Bot deleted the posthog-code/channels-stack-1-activity-refactors branch July 28, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewhog ($$$) Reviews pull requests before humans do

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants