Rendering: Shadows pt 2 by sp0lsh · Pull Request #155 · PolyEngineTeam/PolyEngine

sp0lsh · 2018-09-10T23:13:36Z

Depends on: #158

References:
https://github.com/TheRealMJP/Shadows
https://github.com/bartwronski/CSharpRenderer
https://docs.microsoft.com/pl-pl/windows/desktop/DxTechArts/common-techniques-to-improve-shadow-depth-maps
https://gamedev.stackexchange.com/questions/73851/how-do-i-fit-the-camera-frustum-inside-directional-light-space

…debug

…nd far planes based on scene intersection and moving light in texel-sized increments

JDuchniewicz · 2018-09-12T13:12:10Z

PolyEngine/RenderingDevice/OpenGL/Src/GLWorldRendering.cpp

 #include "Common/PrimitiveCube.hpp"
 #include "Common/PrimitiveQuad.hpp"
-
+#include "Debugging//DebugDrawSystem.hpp"


unnessecary double forwardslash

# Conflicts: # PolyEngine/Engine/Src/Engine.cpp

…, seems ok

…lyEngine into rendering/shadows-pt-2

MuniuDev · 2018-12-01T14:16:23Z

PolyEngine/Core/Src/Math/AABox.hpp

+		/// <see cref="AABox.Contains()"/>
+		inline bool Intersects(const AABox& rhs) const
+		{	
+			return (abs(Min.X - rhs.Min.X) * 2.0f < (Size.X + rhs.Size.X))


There is Vector::abs method (or at least should be), use it.

BasicMath.hpp has Poly::abs for float, double and long double overloads but no Vector.

Ok, I added this to trello.

PolyEngine/Core/Src/Math/AABox.hpp

PolyEngine/Engine/Res/Shaders/evsm.blur.frag.glsl

MuniuDev · 2018-12-01T14:24:18Z

PolyEngine/Engine/Res/Shaders/evsm.inc.glsl

+    vec2 depthScale = uEVSMBias * 0.01 * exponents * warpedDepth;
+    vec2 minVariance = depthScale * depthScale;
+
+	return ChebyshevUpperBound(moments.xy, warpedDepth.x, minVariance.x, uLightBleedingReduction);


please check your indentation setting in the IDE. These files are all over the place.

MuniuDev · 2018-12-01T14:24:44Z

PolyEngine/Engine/Res/Shaders/evsm.resolve.frag.glsl

+    outputEVSM[3] = vec4(warpedDepth[3], warpedDepth[3] * warpedDepth[3]);
+
+	vec4 finalOutput = outputEVSM[0] + outputEVSM[1] + outputEVSM[2] + outputEVSM[3];
+    finalOutput *= 0.25f;


indentation inconsistency

MuniuDev · 2018-12-01T14:40:56Z

PolyEngine/RenderingDevice/OpenGL/Src/TiledForwardRenderer.cpp

-#include <Proxy/GLShaderProgram.hpp>
-#include <Common/PrimitiveCube.hpp>
-#include <Common/PrimitiveQuad.hpp>
+#include "GLRenderingDevice.hpp"


Please conform to the new convention of using <> instead of quotes for the includes. This applies to the whole PR.

Updated all includes is GLRenderingDevice

MuniuDev · 2018-12-01T14:41:45Z

PolyEngine/RenderingDevice/OpenGL/Src/TiledForwardRenderer.cpp

+	// 
+	// glBindFramebuffer(GL_FRAMEBUFFER, 0);
+	// 
+	// CHECK_FBO_STATUS();


Remove commented code.

MuniuDev · 2018-12-01T14:42:37Z

PolyEngine/RenderingDevice/OpenGL/Src/TiledForwardRenderer.cpp

 	glViewport(0, 0, screenSize.Width, screenSize.Height);

-	for (int i = 9; i > 0; --i)
+	for (int i = 10; i > 0; --i)


Magic number alert.

Moved to constant

MuniuDev · 2018-12-01T14:43:34Z

PolyEngine/RenderingDevice/OpenGL/Src/TiledForwardRenderer.cpp

 	glBindVertexArray(0);

-	for (int i = 9; i > 0; --i)
+	for (int i = 10; i > 0; --i)


Magic number.

Moved to constant

MuniuDev · 2018-12-01T14:44:30Z

PolyEngine/RenderingDevice/OpenGL/Src/TiledForwardRenderer.hpp

+		// GLuint FBOShadowMapResolve1;
+		// GLShaderProgram ShadowMapShader;
+		// GLShaderProgram EVSMResolveShader;
+		// GLShaderProgram EVSMBlurShader;


Remove commented code.

* test case * calculating light bounds in AABox around frustum in game example for debug * added tight projection around camera frustum, light projection near and far planes based on scene intersection and moving light in texel-sized increments * shadow bug dependent on camera direction * imgui reacting to input and drawing on screen from render device * proper init, render deinit and windows created by game * comments * comments * commented #pragma failing travis ci * removed #pragma * removed pragma from resource * commented unused components * commented out wrong variable doh... * prototype of shadow casters culling * moved code to rendering device, tested on example scene and on sponza, seems ok * added AABox around every drawn mesh and still fails on sponza * removed shadow casters AABox * stable shadows working on sponza and test scene * stable shadowmap * interpolated Percentage Closer Filtering * shadows prototype cleanup * shadow ramblings * merged with dev * cmake attempt * moved imgui to third parties, cmake updated for Engine, RenderingDevice and Game Project. Spams a lot * removed sanity spam * resource cleanup * imguisystem cleanup * imgui world component cleanup * added non windows API attributes to imconfig.h * moved imgui to pch * silencing third party gcc -Wimplicit-fallthrough= * enabled -fPIC (Position Independent Code) for imgui static lib to be included in shared libs * fixing gcc includes * fixing cgg includes * made includes same as in GLTextureDeviceProxy * removed commented out code * ImguiUpdate is now in System, Imgui context creation moved to ImguiSystem constructor, removed Resource and WorldComponent * moved Imgui to Engine subdirectory * Added clipboard support, tweaked mouse handling and input that can be consumed by any system * added UTF8 char input from keyboard keys * fixing input consumption (works on all widowns: engine and game) * added output queue and events handled by SDL * CI fix * CI fix and cleanup * CI fix * CI fix * fix * Moved getting axis vector from MovementSystem to EntityTransform * shadowmap ortho projection has correct direction based on dir light forward vector * shadowmap projection in [0, 1] range * stable shadows on frustum transform and properties change * shadows prototype with tight bound around frustum and ortho projection in [0, 1] on Z * more changes * tweaks to AABB intersection tests * added tweakable shadow bias and glPolygonOffset * working evsm2 and evsm4 * shadow projection working with shadow bounds extended by vertical shadow casters * some EVSM4 shadows that work * created pass with shadowmap * switched renderer to use Shadommap pass * parametrizing shadow types * EVSM2 seems to work as well * removed debug light parameters, shadowmap pass has pcf and evsm versions * removed debug variables from light and camera components * CI fix * CI fix * CI fix * CI fix * CI Fix * debug rendering cleanup * cleanup and comments * cleanup * compilation fix * cleanup * cleanup * ignore shader dump extension * fix * Added comment for .dump file extention * cleanup * AABB unit tests * CI fix, tabbed documents * CI fix, tabbed documents * review fix, tabbed code * assert and nullptr fix * None RenderingSettingsComponent fix * review fix * review fix, updated includes * review fix, removed commented code * magic variable moved to constant * CI fix * CI fix

Michal Kłos added 3 commits September 9, 2018 01:14

test case

f6b6e56

calculating light bounds in AABox around frustum in game example for …

f1ce6af

…debug

added tight projection around camera frustum, light projection near a…

4262193

…nd far planes based on scene intersection and moving light in texel-sized increments

sp0lsh mentioned this pull request Sep 10, 2018

Rendering: Shadow pt 2 WIP KNTGPolygon/PolyEngineExamples#12

Closed

sp0lsh changed the title ~~Rendering: Sshadows pt 2 WIP~~ Rendering: Shadows pt 2 WIP Sep 11, 2018

MuniuDev changed the title ~~Rendering: Shadows pt 2 WIP~~ [WIP] Rendering: Shadows pt 2 Sep 11, 2018

sp0lsh mentioned this pull request Sep 11, 2018

SandboxRendering: Shadows pt 2 KNTGPolygon/PolyEngineExamples#13

Open

2 tasks

shadow bug dependent on camera direction

e1eada7

JDuchniewicz reviewed Sep 12, 2018

View reviewed changes

sp0lsh added 21 commits September 25, 2018 22:19

imgui reacting to input and drawing on screen from render device

924fc01

proper init, render deinit and windows created by game

cceace4

comments

8d4f0e0

comments

f16f8d5

Merge branch 'dev' into fet/imgui

7f23fd5

# Conflicts: # PolyEngine/Engine/Src/Engine.cpp

commented #pragma failing travis ci

ef0e789

removed #pragma

8befcc8

removed pragma from resource

c5f2ab8

commented unused components

4ac9b58

commented out wrong variable doh...

c5cab92

prototype of shadow casters culling

8522b8f

moved code to rendering device, tested on example scene and on sponza…

3c4215e

…, seems ok

added AABox around every drawn mesh and still fails on sponza

1bd2719

removed shadow casters AABox

a999afa

stable shadows working on sponza and test scene

5d78698

stable shadowmap

9bd85a7

interpolated Percentage Closer Filtering

a121570

shadows prototype cleanup

168d9a4

shadow ramblings

85866ba

Merge branch 'dev' into fet/imgui

3ee3414

merged with dev

b2eddea

sp0lsh added 6 commits November 25, 2018 19:22

debug rendering cleanup

c68508a

cleanup and comments

e60202e

cleanup

02279c9

compilation fix

8308170

cleanup

78c1a0e

cleanup

c3d708e

sp0lsh changed the title ~~[WIP] Rendering: Shadows pt 2~~ Rendering: Shadows pt 2 Nov 25, 2018

sp0lsh and others added 7 commits November 25, 2018 22:43

ignore shader dump extension

ff522f2

fix

e565d53

Added comment for .dump file extention

ed965e4

cleanup

5ff85ae

AABB unit tests

e1e9eb6

Merge branch 'rendering/shadows-pt-2' of https://github.com/sp0lsh/Po…

1afdff3

…lyEngine into rendering/shadows-pt-2

Merge branch 'dev' into rendering/shadows-pt-2

ad72f20

MuniuDev requested changes Dec 1, 2018

View reviewed changes

sp0lsh added 11 commits December 12, 2018 02:05

CI fix, tabbed documents

3b76a3c

CI fix, tabbed documents

5f36766

review fix, tabbed code

eb4bb6a

assert and nullptr fix

bbf2823

None RenderingSettingsComponent fix

bd69205

review fix

880fb99

review fix, updated includes

39baf37

review fix, removed commented code

12abc19

magic variable moved to constant

6518669

CI fix

54ce36f

CI fix

2378f9b

MuniuDev approved these changes Dec 16, 2018

View reviewed changes

MuniuDev merged commit ee36b8b into PolyEngineTeam:dev Dec 16, 2018

Conversation

sp0lsh commented Sep 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sp0lsh commented Sep 10, 2018 •

edited

Loading